Disable creation of local XC-20s & remove tests #2508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Substrate local XC-20 assets have been deprecated in favor of EVM ERC20 XCM tokens. This is the first of multiple PRs to deprecate
localAssets
in Moonbeam.Sets the
ForceOrigin
ofLocalAsset
config toNever
and remove related tests.What important points reviewers should know?
Even though local assets are meant to be registered through
assetManager.registerLocalAsset
, setting thelocalAssets
config origin to never is enough to make that extrinsic fail, effectually disabling the creation of new local XC20s, as shown with a dev env:Is there something left for follow-up PRs?
Existing local XC20s in Moonbeam are not actively used. After the assets has been destroyed (through governance), follow-up PRs should be made to remove the
localAssets
pallet from the runtime