Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Withdrawability check #2523

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Withdrawability check #2523

merged 2 commits into from
Oct 16, 2023

Conversation

notlesh
Copy link
Contributor

@notlesh notlesh commented Oct 13, 2023

What does it do?

Addresses a corner case where RPC doesn't reject a transaction that it should.

@notlesh notlesh added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited breaking Needs to be mentioned in breaking changes labels Oct 13, 2023
@github-actions
Copy link
Contributor

Coverage generated "Fri Oct 13 20:08:05 UTC 2023":
https://d3ifz9vhxc2wtb.cloudfront.net/pulls/2523/html/index.html

Master coverage: 87.39%
Pull coverage:

librelois
librelois approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@librelois librelois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This short-term fix seem's to work, but it would be better to migrate to Fungible traits and use Inspect::reducible_balance instead

@notlesh notlesh merged commit 6f43844 into master Oct 16, 2023
30 of 35 checks passed
@notlesh notlesh deleted the notlesh-withdrawability-check branch October 16, 2023 22:32
rimbi pushed a commit that referenced this pull request Oct 18, 2023
@notlesh
Withdrawability check (#2523)
18983ce 
* Bump frontier commit

* Impl can_withdraw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@librelois librelois librelois approved these changes

Assignees
No one assigned
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notlesh @librelois