Fix Delegation through Proxy Pallet

[ahmadkaouk]

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

[github-actions]

Coverage generated "Thu Oct 19 10:05:42 UTC 2023":
https://d3ifz9vhxc2wtb.cloudfront.net/pulls/2533/html/index.html

Master coverage: 79.91%
Pull coverage:

[librelois]

@ahmadkaouk you need to account for 1 more db read in the weights for proxy.proxy in file runtime/common/src/weights/pallet_proxy.rs

[ahmadkaouk]

@ahmadkaouk you need to account for 1 more db read in the weights for proxy.proxy in file runtime/common/src/weights/pallet_proxy.rs

@librelois Is it necessary? I believe the filter check is performed in validate_transaction, which is called by the Client before the transaction enters the transaction pool. Additionally, in this case, the error is returned by rpc-core "RPC-CORE: submitExtrinsic(extrinsic: Extrinsic): Hash:: 1010: Invalid Transaction: Transaction call is not expected." Do we still need to consider a database read in this scenario?

[librelois]

@ahmadkaouk you need to account for 1 more db read in the weights for proxy.proxy in file runtime/common/src/weights/pallet_proxy.rs

@librelois Is it necessary? I believe the filter check is performed in validate_transaction, which is called by the Client before the transaction enters the transaction pool. Additionally, in this case, the error is returned by rpc-core "RPC-CORE: submitExtrinsic(extrinsic: Extrinsic): Hash:: 1010: Invalid Transaction: Transaction call is not expected." Do we still need to consider a database read in this scenario?

Yes it's necessary, because the filter is re-executed in the block execution (all transaction validation checks are redone during block execution, to ensure that the block contains only valid transactions).

[librelois]

@ahmadkaouk can you add a reminder message in the script scripts/benchmarking.sh, to make sure that the engineer that will run this script will not erase the manual change?