-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow async backing in moonbase #2593
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
force-pushed
the
elois-async-backing
branch
from
December 19, 2023 13:36
aeff0cd
to
c4cd902
Compare
librelois
force-pushed
the
elois-async-backing
branch
from
December 20, 2023 11:05
f69453a
to
62d87f5
Compare
librelois
changed the title
WIP: Enable async backing in moonbase
Allow async backing in moonbase
Dec 20, 2023
Coverage Report@@ Coverage Diff @@
## master elois-async-backing +/- ##
=======================================================
- Coverage 81.05% 81.01% -0.04%
+ Files 286 287 +1
+ Lines 94172 94254 +82
=======================================================
+ Hits 76322 76353 +31
+ Misses 17850 17901 +51
|
Agusrodri
reviewed
Dec 21, 2023
Agusrodri
approved these changes
Dec 22, 2023
ahmadkaouk
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B5-clientnoteworthy
Changes should be mentioned in any downstream projects' release notes
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
D9-needsaudit👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Runtimes part
UnincludedSegmentApi
to moonbase runtimeruntime.RelayTimestampNow
populated with the relay timestamp at the parachain system inherentRelayTimestamp
that implement the traitTime
and return the value in storage itemruntime.RelayTimestampNow
ConsensusHook
to read the relay timestamp from the relay storage proof and store it.Before this PR, the timestamp implementation for EVM came from the pallet timestamp, we don't use this pallet anymore.
Manual Migration
A new storage item
runtime.RelayGenesisTime
should be populated with the genesis timestamp of the relay in milliseconds.Client part
Refactor moonbeam node services to use the new moonkit api introduced in this PR: Moonsong-Labs/moonkit#14
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?