Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade polkadot-sdk to version 1.7.2 #2700

Merged
merged 83 commits into from
Mar 26, 2024
Merged

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Mar 6, 2024

What does it do?

This PR updates polkadot-sdk dependencies to version 1.7.2.

What important points reviewers should know?

Polkadot-sdk version 1.7.2 includes XCMv4, which removes the Multi prefix in many places, changes some XCM syntax (examples below) and removes Abstract variant from AssetId.

New syntax for building locations and junctions

Now junctions are built using the following methods:

let location = Location {
    parents: 1,
    interior: [Parachain(1000), PalletInstance(50), GeneralIndex(1984)].into()
};

or

let location = Location::new(1, [Parachain(1000), PalletInstance(50), GeneralIndex(1984)]);

And they are matched like so:

match location.unpack() {
  (1, [Parachain(id)]) => ...
  (0, Here) => ...,
  (1, [_]) => ...,
}

This syntax is mandatory in v4, and has been also implemented for v2 and v3 for easier migration.

This was needed to make all sizes smaller.

Removed Abstract asset id

Now assets are just constructed as follows:

let asset: Asset = (AssetId(Location::new(1, Here)), 100u128).into();
No need for specifying Concrete anymore.

Is there something left for follow-up PRs?

NO

Are there relevant PRs or issues in other repositories (Polkadot-sdk, Frontier)?

Runtime API

Identity pallet:

XCM:

RewardDestination

RPC

Client

Try-Runtime

Moonkit

What value does it bring to the blockchain users?

@RomarQ RomarQ added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited breaking Needs to be mentioned in breaking changes labels Mar 6, 2024
@RomarQ RomarQ self-assigned this Mar 6, 2024
@RomarQ RomarQ mentioned this pull request Mar 6, 2024
2 tasks
Copy link
Contributor

github-actions bot commented Mar 20, 2024

Coverage Report

@@                      Coverage Diff                      @@
##           master   rq/update-polkadot-v1.7.2      +/-   ##
=============================================================
- Coverage   73.44%                      72.51%   -0.93%     
  Files         229                         229              
+ Lines       70351                       70565     +214     
=============================================================
- Hits        51669                       51164     -505     
+ Misses      18682                       19401     +719     
Files Changed Coverage
/pallets/erc20-xcm-bridge/src/erc20_matcher.rs 91.86% (-0.91%) 🔽
/pallets/erc20-xcm-bridge/src/lib.rs 9.86% (+0.96%) 🔼
/pallets/xcm-transactor/src/lib.rs 85.48% (-0.16%) 🔽
/pallets/xcm-transactor/src/mock.rs 95.70% (+0.66%) 🔼
/precompiles/crowdloan-rewards/src/mock.rs 14.74% (-84.43%) 🔽
/precompiles/identity/src/lib.rs 90.17% (+0.15%) 🔼
/precompiles/relay-encoder/src/lib.rs 65.02% (+2.69%) 🔼
/precompiles/relay-encoder/src/mock.rs 5.26% (+0.01%) 🔼
/precompiles/relay-encoder/src/tests.rs 98.62% (+0.03%) 🔼
/precompiles/utils/src/solidity/codec/xcm.rs 67.09% (-0.86%) 🔽
/precompiles/utils/src/testing/account.rs 58.09% (-20.91%) 🔽
/precompiles/utils/src/tests.rs 99.26% (-0.01%) 🔽
/precompiles/xcm-transactor/src/functions.rs 96.78% (-0.02%) 🔽
/precompiles/xcm-transactor/src/mock.rs 96.68% (+1.17%) 🔼
/precompiles/xcm-utils/src/mock.rs 97.51% (+0.67%) 🔼
/precompiles/xtokens/src/lib.rs 95.70% (-0.02%) 🔽
/precompiles/xtokens/src/mock.rs 15.09% (-1.16%) 🔽
/precompiles/xtokens/src/tests.rs 99.51% (-0.01%) 🔽
/primitives/account/src/lib.rs 62.69% (-1.54%) 🔽

Coverage generated Mon Mar 25 11:26:38 UTC 2024

@RomarQ RomarQ merged commit e70ee0d into master Mar 26, 2024
27 checks passed
@RomarQ RomarQ deleted the rq/update-polkadot-v1.7.2 branch March 26, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants