-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration to remove collective v1 storage #2711
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noandrea
added
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
D3-trivial
PR contains trivial changes in a runtime directory that do not require an audit
not-breaking
Does not need to be mentioned in breaking changes
labels
Mar 20, 2024
noandrea
changed the title
Add migration to remove collective v1 msmbers
Add migration to remove collective v1 storage
Mar 20, 2024
RomarQ
reviewed
Mar 20, 2024
RomarQ
reviewed
Mar 20, 2024
noandrea
added
the
D1-runtime-migration
PR introduces code that might require downstream chains to run a runtime upgrade.
label
Mar 29, 2024
Coverage Report@@ Coverage Diff @@
## master noandrea-govv1-collective-storage +/- ##
=====================================================================
- Coverage 72.49% 72.47% -0.02%
Files 229 229
+ Lines 70653 70676 +23
=====================================================================
Hits 51219 51219
+ Misses 19434 19457 +23
|
RomarQ
reviewed
Apr 1, 2024
RomarQ
reviewed
Apr 1, 2024
RomarQ
approved these changes
Apr 1, 2024
Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
D1-runtime-migration
PR introduces code that might require downstream chains to run a runtime upgrade.
D3-trivial
PR contains trivial changes in a runtime directory that do not require an audit
not-breaking
Does not need to be mentioned in breaking changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Removes the storage entries for the Gov V1 collectives
What important points reviewers should know?
This is a followup PR from #2643 that did not properly clear the storage.
How to test
The PR can be tested with the try runtime command with the following steps:
Run the tests:
Moonbase
Moonriver
Moonbeam (only when 2801 is enacted)