Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration to remove collective v1 storage #2711

Merged
merged 7 commits into from
Apr 3, 2024

Conversation

noandrea
Copy link
Collaborator

@noandrea noandrea commented Mar 20, 2024

What does it do?

Removes the storage entries for the Gov V1 collectives

What important points reviewers should know?

This is a followup PR from #2643 that did not properly clear the storage.

How to test

The PR can be tested with the try runtime command with the following steps:

  • Build the project with try-runtime feature
cargo build --features try-runtime --release

Run the tests:

Moonbase

try-runtime \
--runtime target/release/wbuild/moonbase-runtime/moonbase_runtime.compact.compressed.wasm \
on-runtime-upgrade --print-storage-diff live --uri wss://rpc.api.moonbase.moonbeam.network:443 \
--pallet CouncilCollective TechCommitteeCollective 

Moonriver

try-runtime \
--runtime target/release/wbuild/moonriver-runtime/moonriver_runtime.compact.compressed.wasm \
on-runtime-upgrade --print-storage-diff live --uri wss://rpc.api.moonriver.moonbeam.network:443 \
--pallet CouncilCollective TechCommitteeCollective

Moonbeam (only when 2801 is enacted)

try-runtime \
--runtime target/release/wbuild/moonbeam-runtime/moonbeam_runtime.compact.compressed.wasm \
on-runtime-upgrade --print-storage-diff live --uri wss://rpc.api.moonbeam.network:443 \
--pallet CouncilCollective TechCommitteeCollective

@noandrea noandrea added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Mar 20, 2024
@noandrea noandrea changed the title Add migration to remove collective v1 msmbers Add migration to remove collective v1 storage Mar 20, 2024
@noandrea noandrea marked this pull request as ready for review March 29, 2024 15:29
@noandrea noandrea added the D1-runtime-migration PR introduces code that might require downstream chains to run a runtime upgrade. label Mar 29, 2024
Copy link
Contributor

github-actions bot commented Mar 29, 2024

Coverage Report

@@                          Coverage Diff                          @@
##           master   noandrea-govv1-collective-storage      +/-   ##
=====================================================================
- Coverage   72.49%                              72.47%   -0.02%     
  Files         229                                 229              
+ Lines       70653                               70676      +23     
=====================================================================
  Hits        51219                               51219              
+ Misses      19434                               19457      +23     
Files Changed Coverage

Coverage generated Tue Apr 2 07:58:16 UTC 2024

Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com>
@noandrea noandrea merged commit d204b79 into master Apr 3, 2024
27 checks passed
@noandrea noandrea deleted the noandrea-govv1-collective-storage branch April 3, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-runtime-migration PR introduces code that might require downstream chains to run a runtime upgrade. D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants