add cli option --block-authoring-duration #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B5-clientnoteworthy
RomarQ
approved these changes
Mar 27, 2024
Coverage Report@@ Coverage Diff @@
## master elois-cli-deadline +/- ##
=====================================================
Coverage 72.51% 72.51% 0.00%
Files 229 229
Lines 70565 70565
=====================================================
Hits 51164 51164
Misses 19401 19401
|
ahmadkaouk
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Depending on the performance of a collator, it can happen that a collator fits more computing weight in a block than a validator is able to process, causing the collator to fail to produce blocks and get the rewards.
This PR add an option to the command line client
--block-authoring-durationthat accepts a positive integer representing the amount of time in milliseconds that the client has to produce a block.The value for the block time limit is bounded between 250 and 2000 (0.25s to 2s) with default to 1.5s.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?