-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XCM instructions weights should comply with evm foreign assets #2883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
D3-trivial
PR contains trivial changes in a runtime directory that do not require an audit
breaking
Needs to be mentioned in breaking changes
labels
Jul 29, 2024
Coverage Report@@ Coverage Diff @@
## master elois-xcm-fees +/- ##
==================================================
- Coverage 80.97% 80.96% -0.01%
Files 282 282
+ Lines 81590 81614 +24
==================================================
+ Hits 66065 66071 +6
+ Misses 15525 15543 +18
|
RomarQ
reviewed
Aug 13, 2024
runtime/moonbeam/src/xcm_config.rs
Outdated
Comment on lines
728
to
729
// TODO generate weights | ||
type WeightInfo = (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
RomarQ
reviewed
Aug 13, 2024
runtime/moonriver/src/xcm_config.rs
Outdated
Comment on lines
741
to
742
// TODO generate weights | ||
type WeightInfo = (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
Agusrodri
reviewed
Aug 13, 2024
Agusrodri
previously approved these changes
Aug 13, 2024
Agusrodri
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
D3-trivial
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
With the introduction of evm foreign assets, 3 XCM instructions cost more when they handle evm foreign assets, theses instructions are:
We currently charge only 200 000 cpu-time weights and 7242 proof size bytes, we should charge based on hardcoded gas limit for evm foreign assets operations instead.
What important points reviewers should know?
This PR need to add the new pallet-moonbeam-foreign-assets on moonriver and moonbeam because with have the same XCM benchmarks pallet for all runtimes.
The configuration of the pallet-moonbeam-foreign-assets on moonriver and moonbeam prohibit the creation of evm foreign assets, with
type AssetIdFilter = Nothing;
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?