Add missing benchmarks #2909
Merged
Add missing benchmarks #2909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
requested review from
gonzamontiel,
TarekkMA,
librelois,
ahmadkaouk and
Agusrodri
librelois
previously approved these changes
Aug 21, 2024
RomarQ
added
B7-runtimenoteworthy
Coverage Report@@ Coverage Diff @@
## master rq/add-missing-benchmarks +/- ##
=============================================================
- Coverage 80.96% 80.93% -0.03%
+ Files 282 284 +2
+ Lines 81614 81715 +101
=============================================================
+ Hits 66071 66136 +65
+ Misses 15543 15579 +36
|
ahmadkaouk
approved these changes
Aug 21, 2024
TarekkMA
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Add missing benchmarks for the following pallets:
cumulus_pallet_parachain_systempallet_message_queueWhat important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?