Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: propagate "proof size OutOfGas" error to outer call #2943

Closed
wants to merge 8 commits into from

Conversation

librelois
Copy link
Collaborator

@librelois librelois commented Sep 11, 2024

What does it do?

If an evm subcall fail becasue fo a "proof size OutOfGas" error, make the whole eth transaction revert with OutOfGas error.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

moonbeam-foundation/frontier#225

What value does it bring to the blockchain users?

@librelois librelois added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. breaking Needs to be mentioned in breaking changes labels Sep 11, 2024
Copy link
Contributor

github-actions bot commented Sep 11, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2180 KB (no changes) ✅

Moonbeam runtime: 2136 KB (no changes) ✅

Moonriver runtime: 2136 KB (no changes) ✅

Compared to latest release (runtime-3102)

Moonbase runtime: 2180 KB (+240 KB compared to latest release) ⚠️

Moonbeam runtime: 2136 KB (+236 KB compared to latest release) ⚠️

Moonriver runtime: 2136 KB (+236 KB compared to latest release) ⚠️

Copy link
Contributor

github-actions bot commented Sep 11, 2024

Coverage Report

@@                  Coverage Diff                  @@
##           master   elois-storage-oog      +/-   ##
=====================================================
- Coverage   79.33%              78.70%   -0.63%     
- Files         298                 294       -4     
- Lines       87119               84425    -2694     
=====================================================
- Hits        69114               66440    -2674     
- Misses      18005               17985      -20     
Files Changed Coverage
/pallets/asset-manager/src/lib.rs 84.77% (+6.59%) 🔼
/pallets/moonbeam-xcm-benchmarks/src/weights/generic.rs 2.96% (-1.30%) 🔽
/pallets/moonbeam-xcm-benchmarks/src/weights/mod.rs 12.04% (-1.57%) 🔽
/runtime/common/src/apis.rs 28.23% (-1.60%) 🔽
/runtime/common/src/migrations.rs 97.95% (+25.75%) 🔼
/runtime/moonbase/src/lib.rs 52.93% (+0.08%) 🔼
/runtime/moonbase/src/xcm_config.rs 64.00% (+5.35%) 🔼
/runtime/moonbase/tests/xcm_mock/parachain.rs 60.22% (-0.63%) 🔽
/runtime/moonbase/tests/xcm_mock/statemint_like.rs 61.76% (-1.62%) 🔽
/runtime/moonbase/tests/xcm_tests.rs 99.92% (+0.01%) 🔼
/runtime/moonbeam/src/lib.rs 46.85% (+0.08%) 🔼
/runtime/moonbeam/src/xcm_config.rs 52.63% (+5.16%) 🔼
/runtime/moonbeam/tests/xcm_mock/parachain.rs 60.22% (-0.63%) 🔽
/runtime/moonbeam/tests/xcm_mock/statemint_like.rs 61.76% (-1.62%) 🔽
/runtime/moonbeam/tests/xcm_tests.rs 99.94% (+0.01%) 🔼
/runtime/moonriver/src/lib.rs 47.07% (+0.08%) 🔼
/runtime/moonriver/src/xcm_config.rs 50.53% (+5.08%) 🔼
/runtime/moonriver/tests/xcm_mock/parachain.rs 60.95% (-0.62%) 🔽
/runtime/moonriver/tests/xcm_mock/statemine_like.rs 61.76% (-1.62%) 🔽
/runtime/moonriver/tests/xcm_tests.rs 99.95% (+0.02%) 🔼

Coverage generated Sun Sep 15 12:38:10 UTC 2024

@librelois librelois marked this pull request as ready for review September 16, 2024 12:55
@librelois librelois closed this Sep 16, 2024
@librelois librelois deleted the elois-storage-oog branch September 16, 2024 13:49
@librelois
Copy link
Collaborator Author

Superseded by #2950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants