Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: 🎲 randomize contract size smoke test #3028

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pLabarta
Copy link
Contributor

@pLabarta pLabarta commented Nov 4, 2024

What does it do?

This PR slightly changes the test-ethereum-contract-code.ts smoke test S08 to fetch a random amount of prefixes based on a chance to be included instead of retrieving all of them.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@pLabarta pLabarta added D2-notlive PR doesn't change runtime code (so can't be audited) B0-silent Changes should not be mentioned in any release notes labels Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2260 KB (no changes) ✅

Moonbeam runtime: 2228 KB (no changes) ✅

Moonriver runtime: 2232 KB (no changes) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2260 KB (+232 KB compared to latest release) ⚠️

Moonbeam runtime: 2228 KB (+232 KB compared to latest release) ⚠️

Moonriver runtime: 2232 KB (+240 KB compared to latest release) ⚠️

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Coverage Report

@@                          Coverage Diff                          @@
##           master   pablo/randomize-contract-size-test     +/-   ##
=====================================================================
  Coverage   79.01%                               79.01%   0.00%     
  Files         305                                  305             
  Lines       88447                                88447             
=====================================================================
  Hits        69878                                69878             
  Misses      18569                                18569             
Files Changed Coverage

Coverage generated Mon Nov 4 12:28:09 UTC 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant