Add support for experimental block import strategy #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B5-clientnoteworthy
WASM runtime size check:Compared to target branchMoonbase runtime: 2260 KB (no changes) ✅ Moonbeam runtime: 2232 KB (no changes) ✅ Moonriver runtime: 2224 KB (no changes) ✅ Compared to latest release (runtime-3300)Moonbase runtime: 2260 KB (+232 KB compared to latest release) Moonbeam runtime: 2232 KB (+236 KB compared to latest release) Moonriver runtime: 2224 KB (+232 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master rq/block-import-pipeline +/- ##
============================================================
+ Coverage 74.81% 78.94% +4.13%
- Files 369 303 -66
- Lines 94137 88282 -5855
============================================================
- Hits 70421 69688 -733
- Misses 23716 18594 -5122
|
RomarQ
requested review from
crystalin,
gonzamontiel,
TarekkMA,
ahmadkaouk and
Agusrodri
crystalin
previously approved these changes
Nov 22, 2024
ahmadkaouk
approved these changes
Nov 22, 2024
stiiifff
changed the title
stiiifff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Supersedes #2794
Historically aura was overcharging fork strategy for parachain at block import, but seems no longer necessary.
This PR updates nimbus to remove the NimbusBlockImport type, a wrapper that impl BlockImport only to override the fork strategy.
When using
--experimental-block-import-strategyCLI parameter node will no longer use a custom fork strategy, instead, blocks will be considered asbestwhen imported.