Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old migrations #3072

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Remove old migrations #3072

merged 1 commit into from
Dec 4, 2024

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Dec 4, 2024

What does it do?

Removes old migrations.

@RomarQ RomarQ requested a review from stiiifff December 4, 2024 10:58
@RomarQ RomarQ mentioned this pull request Dec 4, 2024
19 tasks
Copy link
Contributor

github-actions bot commented Dec 4, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2260 KB (no changes) ✅

Moonbeam runtime: 2248 KB (no changes) ✅

Moonriver runtime: 2240 KB (no changes) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2260 KB (+232 KB compared to latest release) ⚠️

Moonbeam runtime: 2248 KB (+252 KB compared to latest release) ⚠️

Moonriver runtime: 2240 KB (+248 KB compared to latest release) ⚠️

@RomarQ RomarQ self-assigned this Dec 4, 2024
@RomarQ RomarQ added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes not-breaking Does not need to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Coverage Report

@@                      Coverage Diff                      @@
##           master   rq/remove-old-migrations2      +/-   ##
=============================================================
+ Coverage   74.39%                      74.58%   +0.19%     
  Files         375                         375              
- Lines       95766                       95682      -84     
=============================================================
+ Hits        71241                       71356     +115     
- Misses      24525                       24326     -199     
Files Changed Coverage
/client/rpc/dev/src/lib.rs 89.16% (+32.53%) 🔼
/client/rpc/finality/src/lib.rs 81.25% (+68.75%) 🔼
/client/rpc/txpool/src/lib.rs 65.38% (+11.53%) 🔼
/client/rpc-core/txpool/src/types/content.rs 70.37% (+70.37%) 🔼
/client/rpc-core/txpool/src/types/inspect.rs 92.31% (+3.85%) 🔼
/runtime/common/src/migrations.rs 98.03% (+31.93%) 🔼

Coverage generated Wed Dec 4 11:48:10 UTC 2024

@RomarQ RomarQ merged commit 1ec16d3 into master Dec 4, 2024
40 of 45 checks passed
@RomarQ RomarQ deleted the rq/remove-old-migrations2 branch December 4, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants