Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local chain specs #3186

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Fix local chain specs #3186

merged 3 commits into from
Feb 6, 2025

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Feb 6, 2025

What does it do?

Fixes the generation of local chain specs, broken in #3138

@RomarQ RomarQ added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Feb 6, 2025
@RomarQ RomarQ self-assigned this Feb 6, 2025
@RomarQ RomarQ changed the title Rq/fix local chain specs Fix local chain specs Feb 6, 2025
@RomarQ RomarQ marked this pull request as ready for review February 6, 2025 09:50
manuelmauro
manuelmauro previously approved these changes Feb 6, 2025
Copy link
Contributor

@manuelmauro manuelmauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

github-actions bot commented Feb 6, 2025

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2416 KB (no changes) 🚨

Moonbeam runtime: 2408 KB (no changes) 🚨

Moonriver runtime: 2384 KB (no changes) ✅

Compared to latest release (runtime-3401)

Moonbase runtime: 2416 KB (+384 KB compared to latest release) 🚨

Moonbeam runtime: 2408 KB (+396 KB compared to latest release) 🚨

Moonriver runtime: 2384 KB (+372 KB compared to latest release) ⚠️

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Coverage Report

@@                     Coverage Diff                      @@
##           master   rq/fix-local-chain-specs      +/-   ##
============================================================
- Coverage   74.61%                     74.52%   -0.09%     
  Files         380                        380              
+ Lines       95983                      96102     +119     
============================================================
  Hits        71611                      71611              
+ Misses      24372                      24491     +119     
Files Changed Coverage
/node/service/src/chain_spec/moonbase.rs 57.89% (-21.39%) 🔽
/node/service/src/chain_spec/moonbeam.rs 23.24% (-8.80%) 🔽
/node/service/src/chain_spec/moonriver.rs 23.24% (-8.80%) 🔽

Coverage generated Thu Feb 6 11:11:04 UTC 2025

@RomarQ RomarQ added the A8-mergeoncegreen Pull request is reviewed well. label Feb 6, 2025
@RomarQ RomarQ mentioned this pull request Feb 6, 2025
14 tasks
@RomarQ RomarQ merged commit 9a571ae into master Feb 6, 2025
42 of 44 checks passed
@RomarQ RomarQ deleted the rq/fix-local-chain-specs branch February 6, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8-mergeoncegreen Pull request is reviewed well. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants