Crystalin add standalone docker image #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think these are good changes that will make life better for us. It seems like a lo of code to build and push the docker image. I wonder if we've considered this action https://github.com/docker/build-push-action I used it successfully in the the cumulus workshop. |
|
Isn't build-push-action already what is used in the workflow ? |
|
Yes, you're right. I got confused by the lines of bash script before it. I guess they are jsut extracting information to use as tags or labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Docker image for the standalone version of moonbeam.
The parachain has been changed to
moonbase-standalone(This will require some upgrade on the documentation @albertov19 )It also removes the test workflow which is now executed inside the build part of the release workflow. We don't need to build the project 2 times (for release and test) and also it should not release a version if the tests are not passing.