-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sudo from Moonriver (and Alphanet temporarily) #650
Conversation
Remember to remove traces in the Rust integration tests. I see
In Moonriver integration tests |
@JoshOrndorff we need to set the pallet index in moonbase I believe, can you do that ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however, there are a lot of changes around the it("should be able to register many accounts - batch : "
test that seem unnecessary. Probably not a big deal if we simply intend to git revert
this soon.
Yeah still I know I added a sudo-dependent test yesterday. I used sudo to enact a democracy proposal. Didnt realize about this PR. I can try to change it to make it be approved by regular means, or do you want to do it @JoshOrndorff ? |
Ideally we would want to move those tests to use democracy, |
This reverts commit 2386b45.
I prepared this one to restore sudo to moonbase. #652 I'll just leave it open until we're ready for it. |
* Revert "Remove sudo from Moonriver (and Alphanet temporarily) (#650)" This reverts commit 2386b45. * remove sudo from moonriver (cherry picked from commit 89d17d5) * also remove it from the integration tests (cherry picked from commit d831ff0) * restore pallet indeces * Revert "Skipping introduced test with sudo (#653)" This reverts commit 4f0bcad.
This PR removes pallet sudo from the moonriver runtime. After this PR the only ways to dispatch with root origin will be through democracy or council.