Local chains export id dependent state #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girazoki
added
the
B5-clientnoteworthy
JoshOrndorff
approved these changes
Aug 12, 2021
|
Looks like one of the scripts broke. Maybe you just need to supply the old default param explicitly? |
|
Yeah in generate-specs we were inserting --parachain-id with a non-existen paraId variable. I renamed it to the correct one. Perhaps now I trigerred it because I slightly changed how this option should be accepted (made it an option in the cli). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes a small discrepancy with local chains.
export-genesis-statewasnt giving the same state as the nodes that were running the chain spec if the parachain-id was not the default one. I opted for an approach similar to what cumulus is doing to fix it.What important points reviewers should know?
This was preventing our local launch script to register parachains in an parachain Id different than the default one.
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?