-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always author in first slot of new round #704
Always author in first slot of new round #704
Conversation
As for the misleading error message, you could add another log statement when we attempt to author at the beginning of a round, something like "you can ignore the following Bad mandatory message"... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@JoshOrndorff shouldn't the label be clientnoteworthy instead of runtime ? |
All the code that changed here is in the runtime. Specifically it is in the Nimbus runtime API. I agree that it feels funny to call this a runtime change though since that code is only ever executed in an off-chain context (called by the collator before authoring). I'm fine with either tag. |
Thinking about it more, I actually think runtime-noteworthy is better for two reasons. For this code to take effect, we need a runtime upgrade, but we don't need a client upgrade, nor will performing a client upgrade help in any way. I still agree it feels weird though since runtime is usually approximately equal to "onchain". |
This PR introduces a temporary work-around to ensure that block production remains reliable even across round transitions.
Quoting from the body of the PR:
Downside
Because all collator nodes will author the first block in the new round while this code in effect, many of them will find that they are not in fact eligible. This will result in most collators displaying the following error a few times at the beginning of each round (every 300 blocks on moonriver).
To make it more clear to collator node operators that this error is expected, harmless, and temporary, we've added an additional log at the beginning of each round that will tell the collator that the
CannotBeAuthor
error will come soon and is not a problem.testing
I really have no idea how to test this...