Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trace_transaction_before_version_3 #719

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Fix trace_transaction_before_version_3 #719

merged 1 commit into from
Aug 20, 2021

Conversation

tgmichel
Copy link
Contributor

Currently we are on DebugRuntimeApi version 3, and introduced changes in trace_transaction signature. For version 2 runtime access, we need to use the trace_transaction_before_version_3.

@tgmichel tgmichel added A0-pleasereview Pull request needs code review. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes labels Aug 20, 2021
@crystalin crystalin added A8-mergeoncegreen Pull request is reviewed well. and removed A0-pleasereview Pull request needs code review. labels Aug 20, 2021
@crystalin crystalin merged commit 894b751 into master Aug 20, 2021
@crystalin crystalin deleted the tgm-trace-transaction-version branch August 20, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crystalin crystalin crystalin approved these changes

@JoshOrndorff JoshOrndorff Awaiting requested review from JoshOrndorff

Assignees
No one assigned
Labels
A8-mergeoncegreen Pull request is reviewed well. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgmichel @crystalin