CI enforces editorconfig compliance #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshOrndorff
force-pushed
the
joshy-editor-config2
branch
from
3aefd34
to
503e19a
Compare
crystalin
approved these changes
Oct 26, 2020
crystalin
reviewed
Oct 26, 2020
|
Status update. This PR is already over 7k lines changed and I'm not done. I think that's more than we want to introduce at once. My next step will be to try again using tabs for indentation in all cases. My hope is that will create many fewer changes. |
JoshOrndorff
commented
Oct 28, 2020
|
When I run prettier locally, it rejects the |
|
I'm at a loss. I simply can't get the prettier CI job to fail. I've introduced two formatting errors into the
Neither of these errors are caught. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CI job to ensure that the repo conforms to our
.editorconfigfile.This should help avoid issues like #26 (comment) by making sure that the code conforms before and after each PR.