Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect maintenance mode to frame system #747

Merged
merged 3 commits into from
Aug 27, 2021
Merged

Connect maintenance mode to frame system #747

merged 3 commits into from
Aug 27, 2021

Conversation

JoshOrndorff
Copy link
Contributor

This PR adds a detail that was missed in #693

While the maintenance mode pallet was installed in the runtime, it was never used by frame system.

@JoshOrndorff JoshOrndorff added A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes C1-low Does not elevate a release containing this beyond "low priority". labels Aug 27, 2021
@crystalin crystalin added A8-mergeoncegreen Pull request is reviewed well. and removed A0-pleasereview Pull request needs code review. labels Aug 27, 2021
nanocryk
nanocryk suggested changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@nanocryk nanocryk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we put back a BaseCallFilter, shouldn't we also put back the filter check inside the TaggedTransactionQueue runtime API impl so that filtered transactions are not included in the block ?

EDIT : I'll push this change soon on this branch.

tgmichel
tgmichel approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@tgmichel tgmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nanocryk nanocryk merged commit 9ede6fc into master Aug 27, 2021
@nanocryk nanocryk deleted the joshy-connect-maintenance-mode branch August 27, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4meta5 4meta5 4meta5 approved these changes

@nanocryk nanocryk nanocryk approved these changes

@tgmichel tgmichel tgmichel approved these changes

@crystalin crystalin crystalin approved these changes

@notlesh notlesh Awaiting requested review from notlesh

Assignees
No one assigned
Labels
A8-mergeoncegreen Pull request is reviewed well. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes C1-low Does not elevate a release containing this beyond "low priority".
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JoshOrndorff @crystalin @tgmichel @nanocryk @4meta5