add try-runtime for moonriver #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
the
B0-silent
notlesh
approved these changes
Aug 29, 2021
Comment on lines
+438
to
+450
| let registry = config.prometheus_config.as_ref().map(|cfg| &cfg.registry); | ||
| let task_manager = | ||
| sc_service::TaskManager::new(config.task_executor.clone(), registry) | ||
| .map_err(|e| { | ||
| sc_cli::Error::Service(sc_service::Error::Prometheus(e)) | ||
| })?; | ||
|
|
||
| Ok(( | ||
| cmd.run::<service::moonbeam_runtime::Block, service::MoonbeamExecutor>( | ||
| config, | ||
| ), | ||
| task_manager, | ||
| )) |
There was a problem hiding this comment.
You might be able to remove some of this duplicated code, but that might also have side effects...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?