-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forge block timestamps in manual seal mode #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also try to readd the ripemd one too ? It was already fixed I believe
I've tested this manually, and this change does allow manual seal to author blocks in quick succession as we expected. But it does not fix the failing tests in |
@JoshOrndorff. My understanding is that those tests are fine with current implementatiuon of frontier + manual sealing. |
Since manual seal was not the root cause of the failing tests, I no longer think it makes sense to merge this code in here. If we ultimately want it, we should wait to get it from Frontier where it has already been merged. I'll close this and re-focus on fixing the tests. |
After discussion with @crystalin I understand we want this quick-authoring functionality in general, not just for one specific issue we were facing, so this should be re-opened. I'll see if it needs updated and then get it ready for merge. |
Do you think we could easily remove the Timestamp + Aura requirement in the Runtime ? and do you think it is worth trying to do so (to reduce the chance of having unexpected behaviors in the tests.) |
To summarize our discussion in slack: The main objective is to support both of the following in the standalone node:
We cannot simply remove aura as it wouldn't support the second criteria. I recommend we merge this PR as it supports both of the listed requirements and follows the same path that Frontier is following upstream cite. |
Tests are failing atm because the actual fix for them is in #82. Once that is merged, we can update this and CI will be green. |
This PR introduces a FAKE timestamp inherent data provider that will always include timestamps that are one aura-slot-duration apart from one another. This allows us to use manual seal to author blocks quickly without violating timestamp assumptions made by either the Aura pallet or the Timestamp pallet.
This code was taken from polkadot-evm/frontier#170. When moonbeam updates to a Frontier version that includes that PR, we should re-evaluate whether it makes sense to keep this here.