Fix empty traces #763
Merged
Fix empty traces #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanocryk
added
A0-pleasereview
tgmichel
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
While #742 introduced new events in the Runtime to correctly trace some transactions that failed previously, it also failed where the previous tracer succeeded for the previous runtime version.
This PR fixes this bug and seems to produce correct traces for the future and current runtime. Future is tested in the TS tests, while current was tested by syncing a node on Moonriver and tracing various transactions that failed to produce a correct trace on currently deployed nodes.
What important points reviewers should know?
Is there something left for follow-up PRs?
The new tracer is client side but is still located in the primitives folder and crate. All client-side code should be refactored out of this crate into the clients folder crates.
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?