Xtokens smart contract selector fix and test #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts + test web3 data
… into xtokens_smart_contract_selector_fix_and_test
joelamouche
reviewed
Oct 13, 2021
girazoki
added
the
B7-runtimenoteworthy
… into xtokens_smart_contract_selector_fix_and_test
joelamouche
reviewed
Oct 13, 2021
joelamouche
suggested changes
Oct 13, 2021
|
The selectors were wrong because they were not using the struct type (u8, bytes[]). However we did not catch that because we were not testing this through a true solidity call. These tests fix that by compiling an instance of the precompiles contract and using the selectors gotten by ethers.js itself. If the selectors are wrong, the calls do not pass. If the selectors are correct, the call passes and the extrinsic is dispatched |
… into xtokens_smart_contract_selector_fix_and_test
…tract_selector_fix_and_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It fixes the selector and adds typescript tests with ether.js to ensure the encoding is correctly done
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?