Update UnitWeightCost in moonbase runtime #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girazoki
added
A0-pleasereview
|
Is this only on Moonbase ? |
JoshOrndorff
approved these changes
Oct 25, 2021
|
Yes, this code only appears in Moonbase. |
|
It's the only runtime where we use XCM instruction charging, so yes. The mock runtime was already charging less, hence the reason why we have not caught this error before. |
girazoki
deleted the
charge_less_to_make_relay_reserve_transfer_assets_work
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
CHarges less amount per xcm instruction to make it work with 0.9.11 pallet_xcm reserve_transfer_assets.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?