Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy genesis companion #934

Merged
merged 20 commits into from
Oct 29, 2021
Merged

Proxy genesis companion #934

merged 20 commits into from
Oct 29, 2021

Conversation

JoshOrndorff
Copy link
Contributor

@JoshOrndorff JoshOrndorff commented Oct 28, 2021 •
edited
Loading

This PR adds a pallet-proxy-genesis-config. This pallet works alongside pallet proxy and allows having proxies configured at genesis.

To configure this is a json spec, add a section that looks like this

"proxyGenesisCompanion": {
  "proxies": [
    [
      "0x3cd0a705a2dc65e5b1e1205896baa2be8a07c6e0",
      "0xf24ff3a9cf04c71dbc94d0b566f7a27b94566cac",
      "NonTransfer",
      100
    ]
  ]
}

@JoshOrndorff JoshOrndorff mentioned this pull request Oct 28, 2021
Closed
@JoshOrndorff JoshOrndorff added A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes C1-low Does not elevate a release containing this beyond "low priority". labels Oct 28, 2021
@JoshOrndorff

This comment has been minimized.

Sign in to view
4meta5
4meta5 approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@4meta5 4meta5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits but looks good

@JoshOrndorff JoshOrndorff added A8-mergeoncegreen Pull request is reviewed well. and removed A0-pleasereview Pull request needs code review. labels Oct 28, 2021
@JoshOrndorff JoshOrndorff merged commit 65752ba into master Oct 29, 2021
@JoshOrndorff JoshOrndorff deleted the joshy-proxy-genesis branch October 29, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4meta5 4meta5 4meta5 approved these changes

@crystalin crystalin crystalin approved these changes

@notlesh notlesh Awaiting requested review from notlesh

Assignees
No one assigned
Labels
A8-mergeoncegreen Pull request is reviewed well. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes C1-low Does not elevate a release containing this beyond "low priority".
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshOrndorff @crystalin @4meta5