Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Blake2 precompile to runtimes #935

Merged
merged 7 commits into from
Nov 4, 2021
Merged

Add Blake2 precompile to runtimes #935

merged 7 commits into from
Nov 4, 2021

Conversation

notlesh
Copy link
Contributor

@notlesh notlesh commented Oct 28, 2021 •
edited
Loading

What does it do?

Adds Blake2 precompile to our runtimes.

TODO:

  • Add dummy code to address 0x9
  • Integration test

@notlesh notlesh added A3-inprogress Pull request is in progress. No review needed at this stage. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes labels Oct 28, 2021
JoshOrndorff
JoshOrndorff approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@JoshOrndorff JoshOrndorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches geth https://github.com/ethereum/go-ethereum/blob/3c46f557/core/vm/contracts.go#L69

@notlesh notlesh added A0-pleasereview Pull request needs code review. and removed A3-inprogress Pull request is in progress. No review needed at this stage. labels Nov 2, 2021
@notlesh
Copy link
Contributor Author

notlesh commented Nov 3, 2021

This is done and mergeable AFAIC

@JoshOrndorff
Copy link
Contributor

JoshOrndorff commented Nov 4, 2021 •
edited
Loading

I believe we were only waiting so that this didn't go into runtime 900 (moonbeam genesis runtime). That is already tagged, so I think we can merge.

@JoshOrndorff JoshOrndorff merged commit 75065fa into master Nov 4, 2021
@JoshOrndorff JoshOrndorff deleted the notlesh-add-blake2-precompile branch November 4, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshOrndorff JoshOrndorff JoshOrndorff approved these changes

Assignees
No one assigned
Labels
A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notlesh @JoshOrndorff