Girazoki runtime 901 moonbase alpha approval fix #974
Conversation
* pallet-assets fixing error matching * Add erc20 instance contract * TS tests with flag to true * More typescript tests * prettier * EditorConfig * Modify integration tests
girazoki
added
the
B7-runtimenoteworthy
| gasometer.record_cost(RuntimeHelper::<Runtime>::db_read_gas_cost())?; | ||
| gasometer.record_cost(RuntimeHelper::<Runtime>::db_write_gas_cost())?; |
There was a problem hiding this comment.
They were wrong. I think they were left-overs from when we were using a local approval storage and not the pallet one. Now the db writes assocaited with the pallet-storage should be returned by the dispatch call itself
| assetId = context.polkadotApi.createType( | ||
| "AssetId", | ||
| new BN("42259045809535163221576417993425387648") | ||
| ); |
There was a problem hiding this comment.
assetId could be deduced by the result of registerAsset.
Otherwise it would be more readable to declare this number as a constant: const testAssetId=new BN("42259045809535163221576417993425387648")
| data: data, | ||
| }, | ||
| ]); | ||
| let amount = new BN(100000000000000); |
There was a problem hiding this comment.
Would be better to derive amount here and in the registration from the same constant, making the test easier to modify and understand
|
@joelamouche can we create a JIRA-tickets for test improvements? I dont want to add to the hotfix branch something that is not in master |
|
Sure pls create a ticket and add details pls |
|
@girazoki |
|
Actually, let's rebase on runtime-901 and merge |
crystalin
changed the base branch from
runtime-901-moonbase-alpha-approval-hotfix
to
perm-runtime-901
crystalin
deleted the
girazoki-runtime-901-moonbase-alpha-approval-fix
branch
What does it do?
Provides hotfix for the approval precompile that was already merge in master.
PR that brought the fix in master: #963
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?