added 18 decimals to chain specs #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
JoshOrndorff
suggested changes
Nov 9, 2020
There was a problem hiding this comment.
I agree with this change, but we should also add it in the Rust code, so it is places in the json by default when we generate new specs in the future.
It would need to go here https://github.com/PureStake/moonbeam/blob/master/node/standalone/src/chain_spec.rs#L91-L92 and the corresponding place in the parachain node.
Here is the struct you would need to add https://substrate.dev/rustdocs/v2.0.0/sc_service/type.Properties.html
JoshOrndorff
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not specified in chain specs, decimals will default to 15.
We should set it to 18, the standard decimal number for ethereum.
solves #98