benchmark pallet asset manager

[girazoki]

What does it do?

Benchmark pallet-asset-manager draft. A new moonbase-runtime-benchmarks flag was added since this pallet is only present on moonbase

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

[notlesh]

Should this imply runtime-benchmarks so you don't need multiple feature flags to use it? You would probably need to do that in a lot of pallets or create an alias in .cargo/config.toml, so maybe not...

[girazoki]

I can try

[girazoki]

The main issue here is that I need to propagate the flag at least till runtime-common, which is the common place where we put our benchmark apis. And since runtime-common is common for all runtimes, I need to have a special flag to incorportate the benchmarks for pallets belonging to moonbase only.

The way I designed it currently is that if you build with moonbase-runtime-bechmarks, it will build with runtime-benchmarks & moonbase-runtime-benchmarks just the moonbase runtime. From here there are two possibilities:

• Leave it as is, where building with features moonbase-runtime-bechmarks compile the moonbase runtime with both runtime-benchmarks and moonbase-runtime-benchmarks
• Make it so that we only have one flag in moonbase called moonbase-runtime-benchmarks, and do something like moonbase-runtime-benchmarks = ["frame-support/runtime-benchmarks", "pallet-society/runtime-benchmarks", etc..]"

Quite honestly I'd rather not be too invasive with this PR, and not change much how things worked. I think this approach is the lesser invasive as things worked as before, but we have a new flag with which we can run the just moonbase benchmarks