fix benchmarks to handle zero existential deposit #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
reviewed
Aug 18, 2023
frame/balances/src/benchmarking.rs
Outdated
| let caller = whitelisted_caller(); | ||
|
|
||
| // Give some multiple of the existential deposit | ||
| let balance = existential_deposit.saturating_mul(ED_MULTIPLIER.into()); |
There was a problem hiding this comment.
why removing the multiplier? We can keep it
There was a problem hiding this comment.
For this benchmark we need the account to be reaped so we can no longer transfer a part of the balance, rather the entire balance needs to be transferred so the benchmark case is respected, which doesn't really need the multiplier.
There was a problem hiding this comment.
I can alternatively also make it to transfer the balance instead of the ED, if that's better.
There was a problem hiding this comment.
Even if the multiplier is useless, my point is to minimize the changes, change only what we strictly need to be able to run the benchmarks
librelois
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pallet-balances and pallet-identity benchmarks to handle
0ExistentialDeposit.