Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xTokens weight param breaking changes #47

Merged
merged 6 commits into from
Dec 6, 2022
Merged

xTokens weight param breaking changes #47

merged 6 commits into from
Dec 6, 2022

Conversation

fgamundi
Copy link
Contributor

@fgamundi fgamundi commented Dec 5, 2022 •
edited
Loading

Description

xTokens transfer extrinsics has been updated, and their destWeight parameter has been changed from u64 to XcmV2WeightLimit

PR of xTokens changes: open-web3-stack/open-runtime-module-library#841

Checklist

  • If this requires a documentation change, I have created a PR in moonbeam-docs repository.
  • If this requires it, I have updated the Readme
  • If necessary, I have updated the examples
  • I have verified if I need to create/update unit tests
  • I have verified if I need to create/update acceptance tests
  • If necessary, I have run acceptance tests on this branch in CI

@fgamundi fgamundi marked this pull request as ready for review December 6, 2022 12:18
ekenigs
ekenigs previously approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@ekenigs ekenigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, the code looks good.

@fgamundi fgamundi merged commit c80f41c into main Dec 6, 2022
@fgamundi fgamundi deleted the fxg/xtokens-weight branch December 6, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekenigs ekenigs ekenigs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgamundi @ekenigs