Merge pull request #3 from kehralexander/patch-1

Bugfix: Delete permissions for roles and rolebindings
moonbeam-nyc · Jun 3, 2024 · b00cdfd · b00cdfd
2 parents 50b18e6 + 1bb5502
commit b00cdfd
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 6 deletions.
diff --git a/charts/snorlax/Chart.yaml b/charts/snorlax/Chart.yaml
@@ -13,9 +13,9 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.4.0
+version: 0.4.1
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "0.4.0"
+appVersion: "0.4.1"
diff --git a/charts/snorlax/templates/manager-rbac.yaml b/charts/snorlax/templates/manager-rbac.yaml
@@ -64,6 +64,7 @@ rules:
   - rolebindings
   verbs:
   - create
+  - delete
   - get
   - list
   - watch
@@ -73,6 +74,7 @@ rules:
   - roles
   verbs:
   - create
+  - delete
   - get
   - list
   - watch

diff --git a/charts/snorlax/values.yaml b/charts/snorlax/values.yaml
@@ -32,7 +32,7 @@ controllerManager:
         - ALL
     image:
       repository: ghcr.io/moonbeam-nyc/snorlax-operator
-      tag: 0.4.0
+      tag: 0.4.1
     resources:
       limits:
         cpu: 500m

diff --git a/operator/config/manager/kustomization.yaml b/operator/config/manager/kustomization.yaml
@@ -5,4 +5,4 @@ kind: Kustomization
 images:
 - name: controller
   newName: ghcr.io/moonbeam-nyc/snorlax-operator
-  newTag: 0.4.0
+  newTag: 0.4.1
diff --git a/operator/config/rbac/role.yaml b/operator/config/rbac/role.yaml
@@ -63,6 +63,7 @@ rules:
   - rolebindings
   verbs:
   - create
+  - delete
   - get
   - list
   - watch
@@ -72,6 +73,7 @@ rules:
   - roles
   verbs:
   - create
+  - delete
   - get
   - list
   - watch

diff --git a/operator/internal/controller/sleepschedule_controller.go b/operator/internal/controller/sleepschedule_controller.go
@@ -57,8 +57,8 @@ const finalizer = "finalizer.snorlax.moonbeam.nyc"
 //+kubebuilder:rbac:groups=networking.k8s.io,resources=ingresses,verbs=get;watch;list;update;patch
 //+kubebuilder:rbac:groups=core,resources=services,verbs=get;watch;list;create;delete
 //+kubebuilder:rbac:groups=core,resources=serviceaccounts,verbs=get;watch;list;create
-//+kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=roles,verbs=get;watch;list;create
-//+kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=rolebindings,verbs=get;watch;list;create
+//+kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=roles,verbs=get;watch;list;create;delete
+//+kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=rolebindings,verbs=get;watch;list;create;delete
 
 func (r *SleepScheduleReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
 	log := log.FromContext(ctx)
-Original file line number
+Diff line change
@@ Expand Up / @@ -64,6 +64,7 @@ rules: @@
       - rolebindings
       verbs:
       - create
+      - delete
       - get
       - list
       - watch
@@ Expand All / @@ -73,6 +74,7 @@ rules: @@
       - roles
       verbs:
       - create
+      - delete
       - get
       - list
       - watch
@@ Expand Down @@