Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XcmExecutorUtils pallet #5

Merged
merged 15 commits into from
Jan 29, 2024
Merged

XcmExecutorUtils pallet #5

merged 15 commits into from
Jan 29, 2024

Conversation

fgamundi
Copy link
Contributor

@fgamundi fgamundi commented Jan 15, 2024

XcmExecutorUtils is a utility pallet to help set the runtime parameters of XcmExecutor

Currently it offers an intuitive, on-chain manager for trust policies on incoming assets though IsReserveFilter and IsTeleporterFilter.

@fgamundi fgamundi changed the title AssetsFiltering pallet XcmExecutorUtils pallet Jan 22, 2024
@fgamundi fgamundi marked this pull request as ready for review January 22, 2024 13:28
Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the pallet looks very good. I would still wait for the upstream PR to get reviewed, just in case we are missing something by enabling the std... If we dont get it accepted we might just have to remove the genesis-build :(

@tmpolaczyk
Copy link
Collaborator

If we dont get it accepted we might just have to remove the genesis-build :(

We can always manually implement Serialize/Deserialize using a wrapper type, but I don't see why wouldn't they accept it

@fgamundi
Copy link
Contributor Author

polkadot-sdk PR has been approved and merged! paritytech/polkadot-sdk#3057

@girazoki
Copy link
Collaborator

I think you can merge this PR unless @tmpolaczyk wants to add something else

@tmpolaczyk
Copy link
Collaborator

Go ahead

@fgamundi fgamundi merged commit c9f5a58 into master Jan 29, 2024
8 checks passed
@fgamundi fgamundi deleted the fg-assets-filtering branch January 29, 2024 16:04
fgamundi added a commit that referenced this pull request Jan 31, 2024
* Assets filtering pallet on master

* Changed structure to have a default and origins policies

* Rename, tests, isTeleportFilter

* Set teleport policies on genesis build

* Test

* Moved tests

* Updated names

* fmt

* IKnit benchmarks

* Removed Default for GenesisConfig. serde on std

* Benchmarks and serde

* fmt

* Cleanup

* Default policies mocks and tests

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants