feat: added as_any implementation to FullClientTransactionPool

moondance-labs · Dec 2, 2024 · f3d164a · f3d164a
1 parent 08a6dc9
commit f3d164a
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 15 deletions.
diff --git a/substrate/client/transaction-pool/src/builder.rs b/substrate/client/transaction-pool/src/builder.rs
@@ -110,19 +110,19 @@ impl TransactionPoolOptions {
 /// This trait defines the requirements for a full client transaction pool, ensuring
 /// that it can handle transactions submission and maintenance.
 pub trait FullClientTransactionPool<Block, Client>:
-	MaintainedTransactionPool<
-		Block = Block,
-		Hash = ExtrinsicHash<FullChainApi<Client, Block>>,
-		InPoolTransaction = Transaction<
-			ExtrinsicHash<FullChainApi<Client, Block>>,
-			ExtrinsicFor<FullChainApi<Client, Block>>,
-		>,
-		Error = <FullChainApi<Client, Block> as ChainApi>::Error,
-	> + LocalTransactionPool<
-		Block = Block,
-		Hash = ExtrinsicHash<FullChainApi<Client, Block>>,
-		Error = <FullChainApi<Client, Block> as ChainApi>::Error,
-	>
+MaintainedTransactionPool<
+	Block = Block,
+	Hash = ExtrinsicHash<FullChainApi<Client, Block>>,
+	InPoolTransaction=Transaction<
+		ExtrinsicHash<FullChainApi<Client, Block>>,
+		ExtrinsicFor<FullChainApi<Client, Block>>,
+	>,
+	Error = <FullChainApi<Client, Block> as ChainApi>::Error,
+> + LocalTransactionPool<
+	Block = Block,
+	Hash = ExtrinsicHash<FullChainApi<Client, Block>>,
+	Error = <FullChainApi<Client, Block> as ChainApi>::Error,
+> + std::any::Any
 where
 	Block: BlockT,
 	Client: sp_api::ProvideRuntimeApi<Block>
@@ -133,6 +133,7 @@ where
 		+ 'static,
 	Client::Api: sp_transaction_pool::runtime_api::TaggedTransactionQueue<Block>,
 {
+	fn as_any(&self) -> &dyn std::any::Any;
 }
 
 impl<Block, Client, P> FullClientTransactionPool<Block, Client> for P
@@ -157,8 +158,11 @@ where
 			Block = Block,
 			Hash = ExtrinsicHash<FullChainApi<Client, Block>>,
 			Error = <FullChainApi<Client, Block> as ChainApi>::Error,
-		>,
+		>+ 'static,
 {
+	fn as_any(&self) -> &dyn std::any::Any {
+		self as &dyn std::any::Any
+	}
 }
 
 /// The public type alias for the actual type providing the implementation of

diff --git a/substrate/client/transaction-pool/src/lib.rs b/substrate/client/transaction-pool/src/lib.rs
@@ -33,7 +33,7 @@ use common::{api, enactment_state};
 use std::{future::Future, pin::Pin, sync::Arc};
 
 pub use api::FullChainApi;
-pub use builder::{Builder, TransactionPoolHandle, TransactionPoolOptions, TransactionPoolType};
+pub use builder::{Builder, TransactionPoolHandle, TransactionPoolOptions, TransactionPoolType, FullClientTransactionPool};
 pub use common::notification_future;
 pub use fork_aware_txpool::{ForkAwareTxPool, ForkAwareTxPoolTask};
 pub use graph::{base_pool::Limit as PoolLimit, ChainApi, Options, Pool};