Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Polkadot SDK stable2409 #759

Merged
merged 28 commits into from
Nov 25, 2024

Conversation

chexware
Copy link
Contributor

@chexware chexware commented Nov 21, 2024

Update dependencies from Polkadot SDK from stable2407 to version stable2409

New extrinsics that require benchmarks after the update:

  • runtime_parachains_inclusion::enact_candidate (Dancelight)
  • runtime_parachains_paras_inherent::enter_empty (Dancelight)
  • pallet_assets::transfer_all (Dancebox, Frontier template, Simple template )

Below are the used forks, please review that cherrypicks have been applied correctly.

Polkadot SDK: https://github.com/moondance-labs/polkadot-sdk/tree/tanssi-polkadot-stable2409
Frontier: https://github.com/moondance-labs/frontier/tree/tanssi-polkadot-stable2409
Moonkit: https://github.com/moondance-labs/moonkit/tree/tanssi-polkadot-stable2409
Dancekit: https://github.com/moondance-labs/dancekit/tree/tanssi-polkadot-stable2409

@chexware chexware added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Nov 21, 2024
Copy link
Contributor

github-actions bot commented Nov 21, 2024

WASM runtime size check:

Compared to target branch

dancebox runtime: 1424 KB (no changes) ✅

flashbox runtime: 820 KB (no changes) ✅

dancelight runtime: 2016 KB (no changes) ✅

container chain template simple runtime: 1124 KB (no changes) ✅

container chain template frontier runtime: 1400 KB (no changes) ✅

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Coverage Report

(master)

@@                             Coverage Diff                             @@
##           master   aleks-update-to-polkadot-sdk-stable2409      +/-   ##
===========================================================================
- Coverage   65.47%                                    65.01%   -0.46%     
  Files         312                                       312              
+ Lines       54503                                     54978     +475     
===========================================================================
+ Hits        35685                                     35741      +56     
+ Misses      18818                                     19237     +419     
Files Changed Coverage
/client/consensus/src/lib.rs 13.22% (-0.23%)
/client/node-common/src/service.rs 48.02% (-0.06%)
/client/service-container-chain/src/data_preservers.rs 80.31% (-0.09%)
/client/service-container-chain/src/service.rs 3.37% (-3.62%)
/container-chains/nodes/frontier/src/command.rs 18.24% (+0.22%)
/container-chains/nodes/frontier/src/rpc/mod.rs 68.60% (+0.10%)
/container-chains/nodes/frontier/src/service.rs 80.25% (+0.19%)
/container-chains/nodes/simple/src/command.rs 18.02% (+0.23%)
/container-chains/nodes/simple/src/rpc.rs 95.24% (-0.11%)
/container-chains/nodes/simple/src/service.rs 88.24% (+0.56%)
/node/src/command.rs 26.85% (+0.18%)
/node/src/rpc.rs 97.87% (-0.05%)
/node/src/service.rs 12.61% (-2.93%)
/pallets/configuration/src/lib.rs 83.65% (-1.29%)
/pallets/registrar/src/lib.rs 87.94% (-0.48%)
/solo-chains/node/tanssi-relay-service/src/dev_service.rs 91.43% (-0.14%)
/solo-chains/runtime/dancelight/src/lib.rs 67.07% (-0.82%)
/solo-chains/runtime/dancelight/src/weights/runtime_parachains_paras_inherent.rs 58.82% (+10.04%)
/solo-chains/runtime/dancelight/src/weights/snowbridge_pallet_ethereum_client.rs 65.38% (+65.38%)

Coverage generated Mon Nov 25 10:27:41 UTC 2024

Aleksandar Brayanov and others added 4 commits November 22, 2024 16:37
@chexware chexware marked this pull request as ready for review November 25, 2024 10:04
@girazoki
Copy link
Collaborator

@chexware I would like to see paritytech/polkadot-sdk#4639 cherry-picked if it's not much trouble. I am fine also merging this and making this another PR. As you wish!

@tmpolaczyk
Copy link
Contributor

I prefer a separate PR for the fork aware for easier reviewing

@chexware chexware merged commit b7cb12f into master Nov 25, 2024
42 checks passed
@chexware chexware deleted the aleks-update-to-polkadot-sdk-stable2409 branch November 25, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants