Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Validators matching external validators smoke test #806

Merged
merged 12 commits into from
Jan 27, 2025

Conversation

chexware
Copy link
Contributor

This PR adds a smoke tests which checks if current validators are matching external validators

@chexware chexware added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code not-breaking Does not need to be mentioned in breaking changes labels Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

WASM runtime size check:

Compared to target branch

dancebox runtime: 1420 KB (no changes) ✅

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 2168 KB (no changes) ✅

container chain template simple runtime: 1124 KB (no changes) ✅

container chain template frontier runtime: 1400 KB (no changes) ✅

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Coverage Report

(master)

@@                                   Coverage Diff                                   @@
##           master   aleks-validators-match-external-validator-smoke-test     +/-   ##
=======================================================================================
  Coverage   65.80%                                                 65.80%   0.00%     
  Files         333                                                    333             
  Lines       58544                                                  58544             
=======================================================================================
  Hits        38522                                                  38522             
  Misses      20022                                                  20022             
Files Changed Coverage

Coverage generated Mon Jan 27 11:15:28 UTC 2025

@chexware chexware marked this pull request as ready for review January 15, 2025 14:40
Aleksandar Brayanov and others added 2 commits January 22, 2025 14:15
…alidators and external validators lists from the last block of the previous era
@chexware chexware requested a review from girazoki January 22, 2025 15:12
Copy link
Contributor

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test looks good @chexware thanks!

@chexware chexware merged commit 21fd2c8 into master Jan 27, 2025
42 checks passed
@chexware chexware deleted the aleks-validators-match-external-validator-smoke-test branch January 27, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants