Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix token + env variable substitution. #1690

Merged
merged 3 commits into from
Oct 13, 2024
Merged

fix: Fix token + env variable substitution. #1690

merged 3 commits into from
Oct 13, 2024

Conversation

milesj
Copy link
Collaborator

@milesj milesj commented Oct 13, 2024

Fixes #1679

Copy link

github-actions bot commented Oct 13, 2024

Run report for ce081ddf (ubuntu-latest, 22)

Total time: 1m 28s | Comparison time: 2m 46s | Estimated savings: 1m 17s (46.6% faster)

Action Time Status Info
🟩 SyncWorkspace 27.3ms Passed
🟩 SetupToolchain(node:~22) 49.7s Passed
🟩 SyncProject(node, types) 3ms Passed
🟩 SyncProject(node, runtime) 3.6ms Passed
🟩 SyncProject(node, website) 3.1ms Passed
🟩 InstallWorkspaceDeps(node:~22) 31.7s Passed
🟦 RunTask(types:lint) 763.4ms Cached
🟦 RunTask(types:typecheck) 904.5ms Cached
🟦 RunTask(types:build) 957.6ms Cached
🟦 RunTask(types:test) 990.3ms Cached
🟦 RunTask(runtime:build) 446.1ms Cached
🟩 RunTask(types:format) 932ms Passed
🟦 RunTask(website:build) 5.8s Cached
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 22
Touched files
CHANGELOG.md
crates/app/src/commands/upgrade.rs
crates/config/src/toolchain_config.rs
crates/project-expander/src/token_expander.rs
crates/project-expander/tests/token_expander_test.rs
packages/types/src/toolchain-config.ts
website/docs/config/toolchain.mdx
website/static/schemas/toolchain.json

Copy link

github-actions bot commented Oct 13, 2024

Run report for ce081ddf (ubuntu-latest, 20)

Total time: 1m 26s | Comparison time: 2m 32s | Estimated savings: 1m 5s (43.1% faster)

Action Time Status Info
🟩 SyncWorkspace 26.7ms Passed
🟩 SetupToolchain(node:~20) 48.2s Passed
🟩 SyncProject(node, types) 3.2ms Passed
🟩 SyncProject(node, runtime) 3.9ms Passed
🟩 SyncProject(node, website) 3.2ms Passed
🟩 InstallWorkspaceDeps(node:~20) 32.6s Passed
🟦 RunTask(types:build) 681.7ms Cached
🟦 RunTask(types:typecheck) 897.2ms Cached
🟦 RunTask(types:lint) 901.2ms Cached
🟦 RunTask(types:test) 936.8ms Cached
🟦 RunTask(runtime:build) 464.7ms Cached
🟩 RunTask(types:format) 939ms Passed
🟦 RunTask(website:build) 4.4s Cached
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 20
Touched files
CHANGELOG.md
crates/app/src/commands/upgrade.rs
crates/config/src/toolchain_config.rs
crates/project-expander/src/token_expander.rs
crates/project-expander/tests/token_expander_test.rs
packages/types/src/toolchain-config.ts
website/docs/config/toolchain.mdx
website/static/schemas/toolchain.json

Copy link

github-actions bot commented Oct 13, 2024

Run report for ce081ddf (ubuntu-latest, 18)

Total time: 1m 27s | Comparison time: 2m 36s | Estimated savings: 1m 8s (43.9% faster)

Action Time Status Info
🟩 SyncWorkspace 31.5ms Passed
🟩 SetupToolchain(node:~18) 50s Passed
🟩 SyncProject(node, types) 2.9ms Passed
🟩 SyncProject(node, runtime) 3.5ms Passed
🟩 SyncProject(node, website) 3.1ms Passed
🟩 InstallWorkspaceDeps(node:~18) 31.9s Passed
🟦 RunTask(types:test) 922.2ms Cached
🟦 RunTask(types:typecheck) 1.1s Cached
🟦 RunTask(types:lint) 1.1s Cached
🟦 RunTask(types:build) 1.1s Cached
🟦 RunTask(runtime:build) 447.2ms Cached
🟩 RunTask(types:format) 1s Passed
🟦 RunTask(website:build) 4s Cached
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 18
Touched files
CHANGELOG.md
crates/app/src/commands/upgrade.rs
crates/config/src/toolchain_config.rs
crates/project-expander/src/token_expander.rs
crates/project-expander/tests/token_expander_test.rs
packages/types/src/toolchain-config.ts
website/docs/config/toolchain.mdx
website/static/schemas/toolchain.json

Copy link

github-actions bot commented Oct 13, 2024

Run report for ce081ddf (windows-latest, 20)

Total time: 1m 51s | Comparison time: 3m 19s | Estimated savings: 1m 27s (44.1% faster)

Action Time Status Info
🟩 SyncWorkspace 29.8ms Passed
🟩 SetupToolchain(node:~20) 54.9s Passed
🟩 SyncProject(node, types) 4.8ms Passed
🟩 SyncProject(node, runtime) 5.2ms Passed
🟩 SyncProject(node, website) 4ms Passed
🟩 InstallWorkspaceDeps(node:~20) 48.9s Passed
🟦 RunTask(types:typecheck) 906.8ms Cached
🟦 RunTask(types:lint) 1.3s Cached
🟦 RunTask(types:test) 1.3s Cached
🟦 RunTask(types:build) 1.4s Cached
🟦 RunTask(runtime:build) 722.4ms Cached
🟩 RunTask(types:format) 1.6s Passed
🟦 RunTask(website:build) 5.4s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 20
Touched files
CHANGELOG.md
crates/app/src/commands/upgrade.rs
crates/config/src/toolchain_config.rs
crates/project-expander/src/token_expander.rs
crates/project-expander/tests/token_expander_test.rs
packages/types/src/toolchain-config.ts
website/docs/config/toolchain.mdx
website/static/schemas/toolchain.json

Copy link

github-actions bot commented Oct 13, 2024

Run report for ce081ddf (windows-latest, 18)

Total time: 1m 46s | Comparison time: 2m 56s | Estimated savings: 1m 9s (39.5% faster)

Action Time Status Info
🟩 SyncWorkspace 31.7ms Passed
🟩 SetupToolchain(node:~18) 51.5s Passed
🟩 SyncProject(node, types) 4.8ms Passed
🟩 SyncProject(node, runtime) 5.3ms Passed
🟩 SyncProject(node, website) 4.1ms Passed
🟩 InstallWorkspaceDeps(node:~18) 49.2s Passed
🟦 RunTask(types:typecheck) 806.3ms Cached
🟦 RunTask(types:test) 837.3ms Cached
🟦 RunTask(types:lint) 1s Cached
🟦 RunTask(types:build) 1.1s Cached
🟦 RunTask(runtime:build) 549ms Cached
🟩 RunTask(types:format) 1.7s Passed
🟦 RunTask(website:build) 4.4s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 18
Touched files
CHANGELOG.md
crates/app/src/commands/upgrade.rs
crates/config/src/toolchain_config.rs
crates/project-expander/src/token_expander.rs
crates/project-expander/tests/token_expander_test.rs
packages/types/src/toolchain-config.ts
website/docs/config/toolchain.mdx
website/static/schemas/toolchain.json

Copy link

github-actions bot commented Oct 13, 2024

Run report for ce081ddf (windows-latest, 22)

Total time: 1m 49s | Comparison time: 3m 5s | Estimated savings: 1m 16s (41.3% faster)

Action Time Status Info
🟩 SyncWorkspace 32.4ms Passed
🟩 SetupToolchain(node:~22) 55.1s Passed
🟩 SyncProject(node, types) 5ms Passed
🟩 SyncProject(node, runtime) 5.4ms Passed
🟩 SyncProject(node, website) 3.9ms Passed
🟩 InstallWorkspaceDeps(node:~22) 46.9s Passed
🟦 RunTask(types:typecheck) 758.5ms Cached
🟦 RunTask(types:lint) 929.3ms Cached
🟦 RunTask(types:test) 962.1ms Cached
🟦 RunTask(types:build) 999.1ms Cached
🟦 RunTask(runtime:build) 556.3ms Cached
🟩 RunTask(types:format) 1.6s Passed
🟦 RunTask(website:build) 5.5s Cached
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 22
Touched files
CHANGELOG.md
crates/app/src/commands/upgrade.rs
crates/config/src/toolchain_config.rs
crates/project-expander/src/token_expander.rs
crates/project-expander/tests/token_expander_test.rs
packages/types/src/toolchain-config.ts
website/docs/config/toolchain.mdx
website/static/schemas/toolchain.json

@milesj milesj merged commit ce081dd into master Oct 13, 2024
26 of 27 checks passed
@milesj milesj deleted the fix-1679 branch October 13, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[bug] unable to substitute env var in command when token is also used in same arg
1 participant