fix: Fix task timeout not applying to retries. #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run report for 120e8e0e
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SyncWorkspace |
28.3ms | Passed | |
| 🟩 | SetupToolchain(node:~20) |
48.9s | Passed | |
| 🟩 | SyncProject(node, types) |
2.5ms | Passed | |
| 🟩 | SyncProject(node, report) |
2.4ms | Passed | |
| 🟩 | SyncProject(node, runtime) |
2.6ms | Passed | |
| 🟩 | SyncProject(node, website) |
3.1ms | Passed | |
| 🟩 | SyncProject(node, nx-compat) |
10ms | Passed | |
| 🟩 | InstallWorkspaceDeps(node:~20) |
32.1s | Passed | |
| 🟦 | RunTask(types:build) |
763.1ms | Cached | |
| 🟦 | RunTask(types:lint) |
989.9ms | Cached | |
| 🟦 | RunTask(types:test) |
1s | Cached | |
| 🟦 | RunTask(types:typecheck) |
486.4ms | Cached | |
| 🟩 | RunTask(types:format) |
1.3s | Passed | |
| 🟦 | RunTask(runtime:typecheck) |
483ms | Cached | |
| 🟦 | RunTask(runtime:build) |
660.8ms | Cached | |
| 🟦 | RunTask(report:test) |
683.6ms | Cached | |
| 🟦 | RunTask(report:build) |
594ms | Cached | |
| 🟦 | RunTask(report:lint) |
472.4ms | Cached | |
| 🟩 | RunTask(report:format) |
865.6ms | Passed | |
| 🟦 | RunTask(report:typecheck) |
518.8ms | Cached | |
| And 13 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | RunTask(runtime:format) |
701.2ms | Passed | |
| 🟦 | RunTask(nx-compat:lint) |
521.5ms | Cached | |
| 🟦 | RunTask(nx-compat:build) |
605.3ms | Cached | |
| 🟦 | RunTask(nx-compat:typecheck) |
467ms | Cached | |
| 🟦 | RunTask(nx-compat:test) |
528.1ms | Cached | |
| 🟩 | RunTask(nx-compat:format) |
857.9ms | Passed | |
| 🟦 | RunTask(runtime:lint) |
489ms | Cached | |
| 🟦 | RunTask(runtime:test) |
510.9ms | Cached | |
| 🟦 | RunTask(website:typecheck) |
749.3ms | Cached | |
| 🟦 | RunTask(website:test) |
513.7ms | Cached | |
| 🟦 | RunTask(website:build) |
4.9s | Cached | |
| 🟦 | RunTask(website:lint) |
4.7s | Cached | |
| 🟩 | RunTask(website:format) |
7.9s | Passed |
Environment
OS: Linux
Matrix:
os = ubuntu-latest
node-version = 20
Touched files
.yarn/versions/a679b82f.yml
CHANGELOG.md
Cargo.lock
crates/action-graph/src/action_graph_builder.rs
crates/action-pipeline/src/action_pipeline.rs
crates/action-pipeline/src/job.rs
crates/action/src/action_node.rs
crates/process/src/lib.rs
crates/project-expander/src/tasks_expander.rs
crates/task-runner/Cargo.toml
crates/task-runner/src/command_executor.rs
packages/types/src/pipeline.ts
Run report for 120e8e0e
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SyncWorkspace |
29.1ms | Passed | |
| 🟩 | SetupToolchain(node:~22) |
50.9s | Passed | |
| 🟩 | SyncProject(node, types) |
3.4ms | Passed | |
| 🟩 | SyncProject(node, runtime) |
3.3ms | Passed | |
| 🟩 | SyncProject(node, nx-compat) |
3.5ms | Passed | |
| 🟩 | SyncProject(node, report) |
7.2ms | Passed | |
| 🟩 | SyncProject(node, website) |
4.1ms | Passed | |
| 🟩 | InstallWorkspaceDeps(node:~22) |
30.8s | Passed | |
| 🟦 | RunTask(types:typecheck) |
649.6ms | Cached | |
| 🟦 | RunTask(types:lint) |
852.8ms | Cached | |
| 🟦 | RunTask(types:test) |
895.9ms | Cached | |
| 🟦 | RunTask(types:build) |
903ms | Cached | |
| 🟦 | RunTask(nx-compat:build) |
509.6ms | Cached | |
| 🟦 | RunTask(runtime:typecheck) |
655.1ms | Cached | |
| 🟦 | RunTask(report:build) |
660.7ms | Cached | |
| 🟩 | RunTask(types:format) |
922.2ms | Passed | |
| 🟦 | RunTask(nx-compat:test) |
477.6ms | Cached | |
| 🟦 | RunTask(nx-compat:lint) |
465.8ms | Cached | |
| 🟦 | RunTask(nx-compat:typecheck) |
611.9ms | Cached | |
| 🟦 | RunTask(runtime:build) |
471.9ms | Cached | |
| And 13 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | RunTask(nx-compat:format) |
908.5ms | Passed | |
| 🟦 | RunTask(report:typecheck) |
542.3ms | Cached | |
| 🟦 | RunTask(report:lint) |
505.3ms | Cached | |
| 🟦 | RunTask(runtime:lint) |
455.1ms | Cached | |
| 🟦 | RunTask(report:test) |
573.2ms | Cached | |
| 🟩 | RunTask(report:format) |
977.1ms | Passed | |
| 🟦 | RunTask(runtime:test) |
488.7ms | Cached | |
| 🟩 | RunTask(runtime:format) |
767ms | Passed | |
| 🟦 | RunTask(website:typecheck) |
627.9ms | Cached | |
| 🟦 | RunTask(website:build) |
4.2s | Cached | |
| 🟦 | RunTask(website:lint) |
4.2s | Cached | |
| 🟦 | RunTask(website:test) |
4.2s | Cached | |
| 🟩 | RunTask(website:format) |
7.7s | Passed |
Environment
OS: Linux
Matrix:
os = ubuntu-latest
node-version = 22
Touched files
.yarn/versions/a679b82f.yml
CHANGELOG.md
Cargo.lock
crates/action-graph/src/action_graph_builder.rs
crates/action-pipeline/src/action_pipeline.rs
crates/action-pipeline/src/job.rs
crates/action/src/action_node.rs
crates/process/src/lib.rs
crates/project-expander/src/tasks_expander.rs
crates/task-runner/Cargo.toml
crates/task-runner/src/command_executor.rs
packages/types/src/pipeline.ts
Run report for 120e8e0e
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SyncWorkspace |
28.6ms | Passed | |
| 🟩 | SetupToolchain(node:~18) |
47.6s | Passed | |
| 🟩 | SyncProject(node, types) |
2.7ms | Passed | |
| 🟩 | SyncProject(node, nx-compat) |
2.8ms | Passed | |
| 🟩 | SyncProject(node, report) |
2.5ms | Passed | |
| 🟩 | SyncProject(node, runtime) |
2.7ms | Passed | |
| 🟩 | SyncProject(node, website) |
3.2ms | Passed | |
| 🟩 | InstallWorkspaceDeps(node:~18) |
32.4s | Passed | |
| 🟦 | RunTask(types:build) |
657ms | Cached | |
| 🟦 | RunTask(types:lint) |
760.8ms | Cached | |
| 🟦 | RunTask(types:test) |
805.2ms | Cached | |
| 🟦 | RunTask(types:typecheck) |
386.8ms | Cached | |
| 🟦 | RunTask(runtime:typecheck) |
393.4ms | Cached | |
| 🟩 | RunTask(types:format) |
1.3s | Passed | |
| 🟦 | RunTask(runtime:build) |
543.9ms | Cached | |
| 🟦 | RunTask(nx-compat:lint) |
399ms | Cached | |
| 🟦 | RunTask(nx-compat:build) |
435.9ms | Cached | |
| 🟦 | RunTask(nx-compat:test) |
408.6ms | Cached | |
| 🟦 | RunTask(nx-compat:typecheck) |
423.7ms | Cached | |
| 🟦 | RunTask(report:test) |
399.9ms | Cached | |
| And 13 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟦 | RunTask(report:build) |
516.4ms | Cached | |
| 🟩 | RunTask(nx-compat:format) |
999.2ms | Passed | |
| 🟩 | RunTask(runtime:format) |
811.4ms | Passed | |
| 🟦 | RunTask(report:typecheck) |
414.3ms | Cached | |
| 🟦 | RunTask(report:lint) |
502.6ms | Cached | |
| 🟩 | RunTask(report:format) |
1s | Passed | |
| 🟦 | RunTask(runtime:test) |
420.8ms | Cached | |
| 🟦 | RunTask(runtime:lint) |
532ms | Cached | |
| 🟦 | RunTask(website:lint) |
512.2ms | Cached | |
| 🟦 | RunTask(website:test) |
546.5ms | Cached | |
| 🟦 | RunTask(website:build) |
3.9s | Cached | |
| 🟦 | RunTask(website:typecheck) |
3.2s | Cached | |
| 🟩 | RunTask(website:format) |
8.4s | Passed |
Environment
OS: Linux
Matrix:
os = ubuntu-latest
node-version = 18
Touched files
.yarn/versions/a679b82f.yml
CHANGELOG.md
Cargo.lock
crates/action-graph/src/action_graph_builder.rs
crates/action-pipeline/src/action_pipeline.rs
crates/action-pipeline/src/job.rs
crates/action/src/action_node.rs
crates/process/src/lib.rs
crates/project-expander/src/tasks_expander.rs
crates/task-runner/Cargo.toml
crates/task-runner/src/command_executor.rs
packages/types/src/pipeline.ts
Run report for 120e8e0e
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SyncWorkspace |
30.3ms | Passed | |
| 🟩 | SetupToolchain(node:~20) |
53.9s | Passed | |
| 🟩 | SyncProject(node, types) |
4.1ms | Passed | |
| 🟩 | SyncProject(node, report) |
4.7ms | Passed | |
| 🟩 | SyncProject(node, nx-compat) |
5.4ms | Passed | |
| 🟩 | SyncProject(node, runtime) |
5.6ms | Passed | |
| 🟩 | SyncProject(node, website) |
4.1ms | Passed | |
| 🟩 | InstallWorkspaceDeps(node:~20) |
49.1s | Passed | |
| 🟦 | RunTask(types:typecheck) |
954.6ms | Cached | |
| 🟦 | RunTask(types:lint) |
1.3s | Cached | |
| 🟦 | RunTask(types:build) |
1.4s | Cached | |
| 🟦 | RunTask(types:test) |
875.4ms | Cached | |
| 🟩 | RunTask(types:format) |
1.9s | Passed | |
| 🟦 | RunTask(nx-compat:build) |
793.8ms | Cached | |
| 🟦 | RunTask(nx-compat:lint) |
757ms | Cached | |
| 🟦 | RunTask(nx-compat:test) |
670.9ms | Cached | |
| 🟦 | RunTask(nx-compat:typecheck) |
764.9ms | Cached | |
| 🟩 | RunTask(nx-compat:format) |
1.7s | Passed | |
| 🟦 | RunTask(report:build) |
760.5ms | Cached | |
| 🟦 | RunTask(runtime:build) |
829.1ms | Cached | |
| And 13 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟦 | RunTask(report:lint) |
680.4ms | Cached | |
| 🟦 | RunTask(report:test) |
731.9ms | Cached | |
| 🟦 | RunTask(report:typecheck) |
716.7ms | Cached | |
| 🟩 | RunTask(report:format) |
1.5s | Passed | |
| 🟦 | RunTask(runtime:lint) |
654.2ms | Cached | |
| 🟦 | RunTask(runtime:typecheck) |
1s | Cached | |
| 🟦 | RunTask(runtime:test) |
649.4ms | Cached | |
| 🟦 | RunTask(website:typecheck) |
738.7ms | Cached | |
| 🟩 | RunTask(runtime:format) |
4.9s | Passed | |
| 🟦 | RunTask(website:build) |
5.5s | Cached | |
| 🟦 | RunTask(website:lint) |
5.6s | Cached | |
| 🟦 | RunTask(website:test) |
2.4s | Cached | |
| 🟩 | RunTask(website:format) |
10.3s | Passed |
Environment
OS: Windows
Matrix:
os = windows-latest
node-version = 20
Touched files
.yarn/versions/a679b82f.yml
CHANGELOG.md
Cargo.lock
crates/action-graph/src/action_graph_builder.rs
crates/action-pipeline/src/action_pipeline.rs
crates/action-pipeline/src/job.rs
crates/action/src/action_node.rs
crates/process/src/lib.rs
crates/project-expander/src/tasks_expander.rs
crates/task-runner/Cargo.toml
crates/task-runner/src/command_executor.rs
packages/types/src/pipeline.ts
Run report for 120e8e0e
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SyncWorkspace |
30.4ms | Passed | |
| 🟩 | SetupToolchain(node:~18) |
51s | Passed | |
| 🟩 | SyncProject(node, types) |
4.4ms | Passed | |
| 🟩 | SyncProject(node, report) |
4.7ms | Passed | |
| 🟩 | SyncProject(node, runtime) |
5.2ms | Passed | |
| 🟩 | SyncProject(node, nx-compat) |
5.9ms | Passed | |
| 🟩 | SyncProject(node, website) |
3.8ms | Passed | |
| 🟩 | InstallWorkspaceDeps(node:~18) |
53.6s | Passed | |
| 🟦 | RunTask(types:test) |
853.8ms | Cached | |
| 🟦 | RunTask(types:typecheck) |
1.2s | Cached | |
| 🟦 | RunTask(types:lint) |
1.2s | Cached | |
| 🟦 | RunTask(types:build) |
1.3s | Cached | |
| 🟦 | RunTask(nx-compat:build) |
684.9ms | Cached | |
| 🟦 | RunTask(nx-compat:test) |
1s | Cached | |
| 🟩 | RunTask(types:format) |
1.8s | Passed | |
| 🟦 | RunTask(nx-compat:typecheck) |
738ms | Cached | |
| 🟩 | RunTask(nx-compat:format) |
1.8s | Passed | |
| 🟦 | RunTask(nx-compat:lint) |
749.4ms | Cached | |
| 🟦 | RunTask(report:build) |
729.8ms | Cached | |
| 🟦 | RunTask(runtime:build) |
880.6ms | Cached | |
| And 13 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟦 | RunTask(report:lint) |
746.9ms | Cached | |
| 🟦 | RunTask(report:test) |
743.5ms | Cached | |
| 🟦 | RunTask(runtime:typecheck) |
772.6ms | Cached | |
| 🟦 | RunTask(report:typecheck) |
738.9ms | Cached | |
| 🟩 | RunTask(report:format) |
1.6s | Passed | |
| 🟦 | RunTask(runtime:lint) |
708.3ms | Cached | |
| 🟦 | RunTask(runtime:test) |
737.2ms | Cached | |
| 🟩 | RunTask(runtime:format) |
1.4s | Passed | |
| 🟦 | RunTask(website:typecheck) |
976.8ms | Cached | |
| 🟦 | RunTask(website:build) |
5.6s | Cached | |
| 🟦 | RunTask(website:lint) |
5.7s | Cached | |
| 🟦 | RunTask(website:test) |
5.7s | Cached | |
| 🟩 | RunTask(website:format) |
14.5s | Passed |
Environment
OS: Windows
Matrix:
os = windows-latest
node-version = 18
Touched files
.yarn/versions/a679b82f.yml
CHANGELOG.md
Cargo.lock
crates/action-graph/src/action_graph_builder.rs
crates/action-pipeline/src/action_pipeline.rs
crates/action-pipeline/src/job.rs
crates/action/src/action_node.rs
crates/process/src/lib.rs
crates/project-expander/src/tasks_expander.rs
crates/task-runner/Cargo.toml
crates/task-runner/src/command_executor.rs
packages/types/src/pipeline.ts
Run report for 120e8e0e
|
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟩 | SyncWorkspace |
30.4ms | Passed | |
| 🟩 | SetupToolchain(node:~22) |
55.7s | Passed | |
| 🟩 | SyncProject(node, types) |
3.9ms | Passed | |
| 🟩 | SyncProject(node, report) |
4.7ms | Passed | |
| 🟩 | SyncProject(node, runtime) |
5.1ms | Passed | |
| 🟩 | SyncProject(node, nx-compat) |
5.8ms | Passed | |
| 🟩 | SyncProject(node, website) |
3.9ms | Passed | |
| 🟩 | InstallWorkspaceDeps(node:~22) |
47.2s | Passed | |
| 🟦 | RunTask(types:typecheck) |
799.1ms | Cached | |
| 🟦 | RunTask(types:lint) |
978.5ms | Cached | |
| 🟦 | RunTask(types:test) |
987.7ms | Cached | |
| 🟦 | RunTask(types:build) |
1s | Cached | |
| 🟦 | RunTask(nx-compat:build) |
644.8ms | Cached | |
| 🟦 | RunTask(nx-compat:lint) |
908.3ms | Cached | |
| 🟦 | RunTask(report:build) |
588.6ms | Cached | |
| 🟦 | RunTask(nx-compat:test) |
539.2ms | Cached | |
| 🟩 | RunTask(types:format) |
1.8s | Passed | |
| 🟦 | RunTask(nx-compat:typecheck) |
626.5ms | Cached | |
| 🟩 | RunTask(nx-compat:format) |
2s | Passed | |
| 🟦 | RunTask(runtime:build) |
628.9ms | Cached | |
| And 13 more... |
Expanded report
| Action | Time | Status | Info | |
|---|---|---|---|---|
| 🟦 | RunTask(report:lint) |
673ms | Cached | |
| 🟦 | RunTask(report:typecheck) |
473.1ms | Cached | |
| 🟦 | RunTask(report:test) |
724.8ms | Cached | |
| 🟦 | RunTask(runtime:lint) |
546.8ms | Cached | |
| 🟦 | RunTask(runtime:test) |
561.2ms | Cached | |
| 🟩 | RunTask(report:format) |
1.6s | Passed | |
| 🟦 | RunTask(runtime:typecheck) |
560.2ms | Cached | |
| 🟩 | RunTask(runtime:format) |
1.6s | Passed | |
| 🟦 | RunTask(website:lint) |
547.5ms | Cached | |
| 🟦 | RunTask(website:build) |
4.5s | Cached | |
| 🟦 | RunTask(website:typecheck) |
3.8s | Cached | |
| 🟦 | RunTask(website:test) |
4.2s | Cached | |
| 🟩 | RunTask(website:format) |
9.6s | Passed |
Environment
OS: Windows
Matrix:
os = windows-latest
node-version = 22
Touched files
.yarn/versions/a679b82f.yml
CHANGELOG.md
Cargo.lock
crates/action-graph/src/action_graph_builder.rs
crates/action-pipeline/src/action_pipeline.rs
crates/action-pipeline/src/job.rs
crates/action/src/action_node.rs
crates/process/src/lib.rs
crates/project-expander/src/tasks_expander.rs
crates/task-runner/Cargo.toml
crates/task-runner/src/command_executor.rs
packages/types/src/pipeline.ts
milesj
force-pushed
the
fix-task-timeout
branch
from
d4d66d6 to
48febbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from the job layer to the command layer.
Fixes #1689