-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependancies to latest versions #101
base: master
Are you sure you want to change the base?
Conversation
…se anyone misses it
Didn't notice this had the CI task - the linting was wrong also. I've pushed a change for both (the linting changed more than just my files due to linter upgrades). Tested the CI action on my fork and it passes now. |
Hi there, Wow this is quite large, thank you for your help with this. Since this is big, especially because it updates discord.js to a newer major release, I'll take some time to check this out during this upcoming weekend. Will keep you posted! 🤙🏻 |
Makes sense - I'm running this on my server and have noticed a couple differences over what I was running previously. I'll keep adding to this if I spot other changes
|
I think this may also resolve #94 as I was seeing similar issues in my testing before upgrading - it seemed to be a intermittent bug, e.g. I would never see the issue when running it in my docker environment but would often see it when running it in a local terminal when debugging |
📝 Checklist
Make sure that your PR fulfills these requirements:
i believe this is true, let me know if not
📄 Description
I went to make a minor change to update the
/say
command response to include the message to be said, in case someone misses it they can still read it. Whilst doing this I noticed it was flaky as to whether it would pick up a message inside a voice channel, and on deeper inspection realised that the dependencies were from before discord even had that feature.Therefore I updated all the dependencies and then fixed any breaking changes.
When it comes to the choice lists I cheated and created a util function to change them from an older format to new rather than changing all the arrays to objects by hand.
Note that the text changes I originally made are only in the English localization (because I do not speak the other languages and don't want to butcher it with a translate tool) and are a subjective improvement. Let me know if you want me to remove them from this PR but you still want the upgrades. If this is a wanted change it probably needs someone who can write in the other languages to make the same change before this is merged, for completeness sake.
📌 Does this PR address any issue?
#78 - but for English language only