batch: tabulate on build/create calls #388
Conversation
| @@ -422,15 +430,15 @@ func TestFile__readFromJson(t *testing.T) { | |||
| } | |||
| batch := file.Batches[0] | |||
| batchControl := batch.GetControl() | |||
| if batchControl.EntryAddendaCount != 2 { | |||
| if batchControl.EntryAddendaCount != 1 { | |||
There was a problem hiding this comment.
@bkmoovio Shouldn't this be 0? The ppd-valid.json file has no addenda records.
There was a problem hiding this comment.
I'm not sure why, but Batch.build calls entryCount++ (which is now 1 + entry.addendaCount()). That doesn't seem right?
There was a problem hiding this comment.
Hi Adam,
EntryAddendaCount in the Company/Batch Control Record and File Control Record can be confusing as it is not the AddendaCount for an Entry. It is (for reference page OR108) the tally for each Entry Detail Record processed and each Addenda Record processed, within either the batch or file, as appropriate. For a BatchPPD with one EntryDetail , and no Addenda05, EntryAddendaCount should be 1, If the one EntryDetail has an Addenda05, EntryAddendaCount would be 2. Hopefully that helps . (Clear as Mud)
For the second question:
Prior to removing addendumer change, the code set entryCount as follows:
for i, entry := range batch.Entries {
entryCount = entryCount + 1 + len(entry.Addendum)....
going forward I had added +1 to entryCount for each entry (EntryDetail) + each Addenda property if the property was defined. Addenda02, len(Addenda05), Addenda98, Addenda99. it looks like you created a function for that which is great. I should have.
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah, okay. Those names are confusing but it makes sense.
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
==========================================
- Coverage 85.41% 84.78% -0.64%
==========================================
Files 107 107
Lines 6774 8813 +2039
==========================================
+ Hits 5786 7472 +1686
- Misses 712 1059 +347
- Partials 276 282 +6
Continue to review full report at Codecov.
|
| @@ -177,7 +179,7 @@ func (f *File) setBatchesFromJSON(bs []byte) error { | |||
| if err := json.Unmarshal(bs, &batches); err != nil { | |||
| return err | |||
| } | |||
| // Clear out any nil batchs | |||
| // Clear out any nil batchess | |||
This change gets rid of the requirements to provide a
batchControland/orfileControlobjects in the JSON for anach.Fileobject.Part of: https://github.com/moov-io/moov-io/pull/12