-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alerting: added slack as a notifier #101
Conversation
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
- Coverage 42.08% 41.60% -0.49%
==========================================
Files 87 88 +1
Lines 3647 3644 -3
==========================================
- Hits 1535 1516 -19
- Misses 1817 1841 +24
+ Partials 295 287 -8
Continue to review full report at Codecov.
|
Is there a use-case for warning alerters? We don't have a setup for determining when warnings occur, so I don't see them as being used now. |
I can remove the warning alerters. I just thought it would be useful to give the option of having a non-critical notifier |
301d801
to
0225281
Compare
I can agree that's a useful feature, but the current code doens't handle it well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
Fixes: #52