Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing batch header partial files #204

Closed

Conversation

jasonbornsteinMOOV
Copy link
Contributor

Workaround for incorrectly created partial files, where entries exist without a BatchHeader record.

Changes

Pass a new parameter AllowMissingBatchHeader: true to ach.ValidateOpts when using ach.NewReader to read an ACH file.

Why Are Changes Being Made

Workaround the issue where partial files (full batches with no file header/control record) are being created without batch headers.

Workaround for incorrectly created partial files, where entries exist without a BatchHeader record.
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (15b9eb4) 47.05% compared to head (db0906f) 47.08%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   47.05%   47.08%   +0.02%     
==========================================
  Files          87       87              
  Lines        3817     3819       +2     
==========================================
+ Hits         1796     1798       +2     
  Misses       1705     1705              
  Partials      316      316              
Files Coverage Δ
internal/incoming/odfi/processor.go 71.95% <100.00%> (+0.34%) ⬆️
internal/service/model_inbound.go 31.25% <ø> (ø)
internal/incoming/odfi/scheduler.go 31.76% <92.30%> (+0.81%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jasonbornsteinMOOV jasonbornsteinMOOV marked this pull request as ready for review October 2, 2023 19:34
@adamdecaf adamdecaf closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants