-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Spanner as a data repository #220
Conversation
47fc82e
to
0f411d3
Compare
Thanks for reviewing this @adamdecaf Still leaving as a draft for now until I get our internal deployments set up and verify the Spanner DML works as expected, then will mark as ready to go! |
Sounds good. Let me know how the testing goes! |
@kevinbarbour Any update on testing this? |
Hey Adam, thanks for checking in. I should have this deployed and tested in the next week or so and we'll be able to get this merged. |
Any updates? |
Still in progress. I know he's working hard on it. Definitely should follow up before end of next week. Thanks for keeping tabs on it. |
There are enough changes pending in achgateway I'm going to release them without adding Spanner. We can easily release achgateway with Spanner when it's ready. |
How's testing going with this? |
Hey Adam, sorry for the delay again. We had some project priorities shift around and this has taken a backseat but I should be able to focus on our rollout of this soon. |
29a0fc0
to
fadcf15
Compare
Hey @adamdecaf sorry again for the delay. I finally got back to work on this project and have tested the use of Spanner in our environment, and all is good. There is a test failure in here that #235 should fix. |
Sounds good, thanks! |
Released in https://github.com/moov-io/achgateway/releases/tag/v0.31.0, thanks! |
Changes
Add support for using Google Cloud Spanner instead of MySQL as a data repository for the achgateway.