feat: respond to CancelACHFile events with FileCancellationResponse #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdecaf
force-pushed
the
feat-cancellation-responses
branch
from
836d081 to
dd50370
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #228 +/- ##
==========================================
+ Coverage 47.61% 47.69% +0.08%
==========================================
Files 97 97
Lines 4379 4426 +47
==========================================
+ Hits 2085 2111 +26
- Misses 1962 1983 +21
Partials 332 332 ☔ View full report in Codecov by Sentry. |
burnettekm
reviewed
Mar 13, 2024
| path := filepath.Join("mergable", m.shard.Name, fmt.Sprintf("%s.ach", cancel.FileID)) | ||
|
|
||
| // Check if the file exists already | ||
| file, _ := m.storage.Open(path) |
There was a problem hiding this comment.
We're just looking for if the file exists. Cancellation can only be successful if the file gets renamed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #141, #142