Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ProtonMail fork of crypto package for openpgp #64

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

alexjplant
Copy link
Contributor

Changes

Use the ProtonMail fork of the golang crypto package for openpgp per the GoLang recommendation and the go-crypto docs:

This module is backwards compatible with x/crypto/openpgp, so you can simply replace all imports of golang.org/x/crypto/openpgp with github.com/ProtonMail/go-crypto/openpgp.

Why Are Changes Being Made

To stop the linter from breaking the build

@alexjplant alexjplant marked this pull request as ready for review September 28, 2021 23:40
@alexjplant alexjplant requested a review from darwinz as a code owner September 28, 2021 23:40
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021

Codecov Report

Merging #64 (a8b6846) into master (e3ea999) will increase coverage by 0.45%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   40.87%   41.33%   +0.45%     
==========================================
  Files          79       79              
  Lines        3053     3053              
==========================================
+ Hits         1248     1262      +14     
+ Misses       1545     1534      -11     
+ Partials      260      257       -3     
Impacted Files Coverage Δ
internal/audittrail/storage_blob.go 55.55% <ø> (ø)
internal/gpgx/keys.go 48.00% <0.00%> (ø)
internal/transform/gpg.go 66.66% <ø> (ø)
internal/upload/sftp.go 65.04% <0.00%> (+2.42%) ⬆️
internal/pipeline/file_receiver.go 32.25% <0.00%> (+9.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3ea999...a8b6846. Read the comment docs.

@alexjplant alexjplant merged commit 6ecea77 into moov-io:master Sep 29, 2021
@alexjplant alexjplant deleted the openpgp-proton-fork branch September 29, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants