Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in Docker container. #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

apapsch
Copy link

@apapsch apapsch commented Feb 14, 2024

I am in the unfortunate circumstance of having to use a Windows machine for development. This change runs tests in a container. The test suite fails on Windows, but my target platform is not Windows, therefore I don't need to fix the code for that OS.

@adamdecaf
Copy link
Member

I'm confused how this is helpful then? If you can't run the sftp server on your machine how does running them in a container help?

@apapsch
Copy link
Author

apapsch commented Feb 14, 2024

The SFTP test server runs fine, it already runs in a Linux container. Executing go test using the native Windows go binary is the problem. The test suite fails. Here is the test suite failure (just in case): fail.log. This patch runs go test in a Linux container, removing Windows from the equation.

@adamdecaf
Copy link
Member

adamdecaf commented Feb 14, 2024

We want the client to function on Windows as similar to how it works on Linux/Mac so avoiding Window in tests doesn't help fix the issue. Failures on windows are probably bugs you'll run into anyway.

It looks like Github Windows runners support Docker so we can enable tests there.

@adamdecaf
Copy link
Member

Can you help figure out how to run tests on Windows? I'm not familiar so trying to find the right command so the sftp image boots up is confusing.

#189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants