Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support index tag #293

Merged
merged 14 commits into from
Oct 30, 2023
Merged

support index tag #293

merged 14 commits into from
Oct 30, 2023

Conversation

mfdeveloper508
Copy link
Contributor

@mfdeveloper508 mfdeveloper508 requested a review from alovak as a code owner October 6, 2023 14:01
@mfdeveloper508 mfdeveloper508 changed the title Support new tag support index tag Oct 6, 2023
alovak
alovak reviewed Oct 6, 2023
View reviewed changes
message.go Outdated Show resolved Hide resolved
alovak
alovak reviewed Oct 6, 2023
View reviewed changes
exp_test.go Outdated Show resolved Hide resolved
alovak
alovak reviewed Oct 6, 2023
View reviewed changes
exp_test.go Outdated Show resolved Hide resolved
alovak
alovak reviewed Oct 6, 2023
View reviewed changes
exp_test.go Outdated Show resolved Hide resolved
alovak
alovak reviewed Oct 6, 2023
View reviewed changes
exp_test.go Outdated Show resolved Hide resolved
alovak
alovak reviewed Oct 6, 2023
View reviewed changes
message.go Outdated Show resolved Hide resolved
alovak
alovak reviewed Oct 6, 2023
View reviewed changes
exp_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023 •
edited
Loading

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (add4df1) 74.64% compared to head (08a9ad8) 74.85%.

❗ Current head 08a9ad8 differs from pull request most recent head 818bce0. Consider uploading reports for the commit 818bce0 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
+ Coverage   74.64%   74.85%   +0.21%     
==========================================
  Files          43       44       +1     
  Lines        2465     2494      +29     
==========================================
+ Hits         1840     1867      +27     
- Misses        400      411      +11     
+ Partials      225      216       -9
Files Coverage Δ
message.go 78.57% <94.44%> (+4.64%) ⬆️
field/composite.go 81.14% <87.50%> (+1.92%) ⬆️
field/index_tag.go 82.50% <82.50%> (ø)
field/string.go 70.86% <9.52%> (-12.47%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

alovak
alovak reviewed Oct 6, 2023
View reviewed changes
message_test.go Outdated Show resolved Hide resolved
@alovak alovak merged commit 8f4cb18 into master Oct 30, 2023
9 checks passed
@alovak alovak deleted the support-new-tag branch October 30, 2023 17:56
@alovak alovak mentioned this pull request Oct 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alovak alovak alovak left review comments

@wadearnold wadearnold Awaiting requested review from wadearnold

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfdeveloper508 @codecov-commenter @alovak