Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add comments to ASCIIHexToBytes to clarify its usage #329

Merged
merged 1 commit into from
Oct 4, 2024
Merged

add comments to ASCIIHexToBytes to clarify its usage #329

merged 1 commit into from
Oct 4, 2024

Conversation

alovak
Copy link
Contributor

@alovak alovak commented Oct 4, 2024 •
edited
Loading

Changes:

  • updated field.Hex to use generic PackerUnpacker implementation.
  • updated comments for ASCIIHexToBytes to reduce the confusion when to/not use it.

@alovak alovak mentioned this pull request Oct 4, 2024
Closed
@alovak alovak merged commit a62ddd3 into master Oct 4, 2024
9 checks passed
@alovak alovak deleted the clarify-ascii-hex-encoding branch October 4, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alovak